Opened 10 years ago

Closed 10 years ago

#9977 closed defect (fixed)

TabContainer: _controllerWidget attribute should be public

Reported by: jake richardson Owned by: bill
Priority: high Milestone: 1.4
Component: Dijit Version: 1.3.2
Keywords: TabController controllerWidget buttonWidget Cc:
Blocked By: Blocking:

Description

The buttonWidget attribute is public, so the controllerWidget attribute should be public likewise, to allow it to be set via a template.

Attachments (1)

TabContainer-making-controllerWidget-public (1.2 KB) - added by jake richardson 10 years ago.
Makes the TabContainer::_controllerWidget public

Download all attachments as: .zip

Change History (4)

Changed 10 years ago by jake richardson

Makes the TabContainer::_controllerWidget public

comment:1 in reply to:  description Changed 10 years ago by jake richardson

Replying to jaek:

The buttonWidget attribute is public, so the controllerWidget attribute should be public likewise, to allow it to be set via a template.

Subject should read "TabContainer::_controllerWidget attribute should be public".

comment:2 Changed 10 years ago by bill

Component: GeneralDijit
Milestone: tbd1.4
Owner: changed from anonymous to bill
Status: newassigned
Summary: TabController::_controllerWidget attribute should be publicTabContainer: _controllerWidget attribute should be public

Via a template? Do you mean to set it via markup, when using the parser?

Or the widgetsInTemplate feature?

comment:3 Changed 10 years ago by bill

Resolution: fixed
Status: assignedclosed

(In [20260]) Make controllerWidget public so that users can set it to something else in markup, although it better to make your own TabContainer? subclass in this case so you don't pull in code (specifically ScrollTabController?) that you don't need.

Fixes #9977 !strict

Note: See TracTickets for help on using tickets.