Opened 10 years ago
Closed 10 years ago
#9977 closed defect (fixed)
TabContainer: _controllerWidget attribute should be public
| Reported by: | jake richardson | Owned by: | bill |
|---|---|---|---|
| Priority: | high | Milestone: | 1.4 |
| Component: | Dijit | Version: | 1.3.2 |
| Keywords: | TabController controllerWidget buttonWidget | Cc: | |
| Blocked By: | Blocking: |
Description
The buttonWidget attribute is public, so the controllerWidget attribute should be public likewise, to allow it to be set via a template.
Attachments (1)
Change History (4)
Changed 10 years ago by
| Attachment: | TabContainer-making-controllerWidget-public added |
|---|
comment:1 Changed 10 years ago by
Replying to jaek:
The buttonWidget attribute is public, so the controllerWidget attribute should be public likewise, to allow it to be set via a template.
Subject should read "TabContainer::_controllerWidget attribute should be public".
comment:2 Changed 10 years ago by
| Component: | General → Dijit |
|---|---|
| Milestone: | tbd → 1.4 |
| Owner: | changed from anonymous to bill |
| Status: | new → assigned |
| Summary: | TabController::_controllerWidget attribute should be public → TabContainer: _controllerWidget attribute should be public |
Via a template? Do you mean to set it via markup, when using the parser?
Or the widgetsInTemplate feature?
comment:3 Changed 10 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
(In [20260]) Make controllerWidget public so that users can set it to something else in markup, although it better to make your own TabContainer? subclass in this case so you don't pull in code (specifically ScrollTabController?) that you don't need.
Fixes #9977 !strict
Makes the TabContainer::_controllerWidget public