Opened 11 years ago
Last modified 5 years ago
#9973 open enhancement
[patch] [ccla] Select: does not allow empty value options
| Reported by: | jake richardson | Owned by: | |
|---|---|---|---|
| Priority: | high | Milestone: | 2.0 |
| Component: | Dijit - Form | Version: | 1.3.2 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description (last modified by )
Empty values for options are automatically processed as MenuSeparators, causing empty valued options being invalid.
Attachments (1)
Change History (13)
Changed 11 years ago by
| Attachment: | DropDownSelect-explicit-separator-type added |
|---|
comment:1 Changed 11 years ago by
| Component: | General → Dijit |
|---|---|
| Owner: | changed from anonymous to Nathan Toone |
| Summary: | DropDownSelect does not allow empty value options → [patch] [ccla] DropDownSelect does not allow empty value options |
Looks like you are covered by Sun's CCLA (you work there)?
Nathan, what do you think? I guess there could be a case where someone wants a blank choice.
comment:2 Changed 11 years ago by
| Milestone: | tbd → 1.5 |
|---|
comment:3 Changed 10 years ago by
| Milestone: | 1.5 → future |
|---|---|
| Owner: | Nathan Toone deleted |
Moving my tickets to future, as I am not currently working on them.
comment:4 Changed 10 years ago by
| Summary: | [patch] [ccla] DropDownSelect does not allow empty value options → [patch] [ccla] Select: does not allow empty value options |
|---|
So this patch apparently changes the behavior of Select so that <option/> shows up as an (blank) MenuItem, rather than a MenuSeparator. That's a break in backwards compatibility, although maybe it's unavoidable if we want to support <option value="">.
Actually, the current code recognizes both <option type="separator"> and <option> as a separator. Although on http://docs.dojocampus.org/dijit/form/Select only the former is documented, so maybe dropping the latter is not such a bad change.
See also #11545.
comment:5 Changed 9 years ago by
| Owner: | set to Douglas Hays |
|---|
comment:6 Changed 9 years ago by
| Component: | Dijit → Dijit - Form |
|---|---|
| Description: | modified (diff) |
| Keywords: | DropDownSelect removed |
comment:7 Changed 7 years ago by
Is there any chance of this patch being accepted and commited?
This feature would help with my client requirements and remove the problem I have with #16555
If there is some problem with backwards compatibility could this be resolved by some new property such as allowBlank?
comment:8 Changed 7 years ago by
| Milestone: | future → 2.0 |
|---|---|
| Type: | defect → enhancement |
Given the break in backwards compatibility, this probably makes sense for 2.0.
comment:9 Changed 7 years ago by
I'm happy just with the knowledge that the change is planned. My workarounds are enough for me for now. Thanks guys.
comment:10 Changed 6 years ago by
| Owner: | Douglas Hays deleted |
|---|---|
| Status: | new → assigned |
comment:11 Changed 6 years ago by
| Status: | assigned → open |
|---|
Patch that requires options to be explicitly set as a separators