Opened 9 years ago

Last modified 3 years ago

#9973 open enhancement

[patch] [ccla] Select: does not allow empty value options

Reported by: jake richardson Owned by:
Priority: high Milestone: 2.0
Component: Dijit - Form Version: 1.3.2
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

Empty values for options are automatically processed as MenuSeparators, causing empty valued options being invalid.

Attachments (1)

DropDownSelect-explicit-separator-type (2.2 KB) - added by jake richardson 9 years ago.
Patch that requires options to be explicitly set as a separators

Download all attachments as: .zip

Change History (13)

Changed 9 years ago by jake richardson

Patch that requires options to be explicitly set as a separators

comment:1 Changed 9 years ago by bill

Component: GeneralDijit
Owner: changed from anonymous to Nathan Toone
Summary: DropDownSelect does not allow empty value options[patch] [ccla] DropDownSelect does not allow empty value options

Looks like you are covered by Sun's CCLA (you work there)?

Nathan, what do you think? I guess there could be a case where someone wants a blank choice.

comment:2 Changed 9 years ago by Nathan Toone

Milestone: tbd1.5

comment:3 Changed 9 years ago by Nathan Toone

Milestone: 1.5future
Owner: Nathan Toone deleted

Moving my tickets to future, as I am not currently working on them.

comment:4 Changed 8 years ago by bill

Summary: [patch] [ccla] DropDownSelect does not allow empty value options[patch] [ccla] Select: does not allow empty value options

So this patch apparently changes the behavior of Select so that <option/> shows up as an (blank) MenuItem, rather than a MenuSeparator. That's a break in backwards compatibility, although maybe it's unavoidable if we want to support <option value="">.

Actually, the current code recognizes both <option type="separator"> and <option> as a separator. Although on http://docs.dojocampus.org/dijit/form/Select only the former is documented, so maybe dropping the latter is not such a bad change.

See also #11545.

comment:5 Changed 8 years ago by Douglas Hays

Owner: set to Douglas Hays

comment:6 Changed 8 years ago by bill

Component: DijitDijit - Form
Description: modified (diff)
Keywords: DropDownSelect removed

comment:7 Changed 6 years ago by Bob Tarling

Is there any chance of this patch being accepted and commited?

This feature would help with my client requirements and remove the problem I have with #16555

If there is some problem with backwards compatibility could this be resolved by some new property such as allowBlank?

comment:8 Changed 6 years ago by bill

Milestone: future2.0
Type: defectenhancement

Given the break in backwards compatibility, this probably makes sense for 2.0.

comment:9 Changed 6 years ago by Bob Tarling

I'm happy just with the knowledge that the change is planned. My workarounds are enough for me for now. Thanks guys.

comment:10 Changed 5 years ago by Douglas Hays

Owner: Douglas Hays deleted
Status: newassigned

comment:11 Changed 5 years ago by Douglas Hays

Status: assignedopen

comment:12 Changed 3 years ago by dylan

Bill, was this handled in Delite/Deliteful??

Note: See TracTickets for help on using tickets.