Opened 10 years ago

Closed 9 years ago

#9971 closed defect (fixed)

StackContainer: calls resize() on selected child when selected child is removed

Reported by: jake richardson Owned by: bill
Priority: high Milestone: 1.5
Component: Dijit Version: 1.3.2
Keywords: StackContainer Cc:
Blocked By: Blocking:

Description (last modified by bill)

StackContainer is calling layout() on child after it removed it.

Attachments (1)

StackContainer-fix-calling-layout-on-removed-selected-page (1.2 KB) - added by jake richardson 10 years ago.
Calls layout() after cleaning up the selectedChildWidget

Download all attachments as: .zip

Change History (11)

Changed 10 years ago by jake richardson

Calls layout() after cleaning up the selectedChildWidget

comment:1 Changed 10 years ago by bill

Component: GeneralDijit
Owner: anonymous deleted

Hmm, you haven't attached a test case, how do I reproduce this?

comment:2 Changed 10 years ago by bill

Milestone: tbd1.4
Owner: set to bill
Status: newassigned
Summary: StackContainer calling layout() on removed childStackContainer: calls resize() on selected child when selected child is removed

Oh I guess I see the problem, that when the selected pane is removed, it calls resize() on that pane, rather than the newly selected pane.

comment:3 Changed 10 years ago by bill

Milestone: 1.41.5

comment:4 Changed 9 years ago by Adam Peller

Milestone: 1.51.6

comment:5 Changed 9 years ago by bill

Description: modified (diff)
Milestone: 1.61.7

comment:6 Changed 9 years ago by bill

(In [25418]) tests that removing a pane from StackContainer doesn't call resize on that pane, refs #9971

comment:7 Changed 9 years ago by bill

Resolution: worksforme
Status: assignedclosed

Hmm, this is working for me, all the way back to 1.4. Can you reproduce the problem anymore? (See my test cases I checked in above.)

comment:8 Changed 9 years ago by bill

(In [25419]) tests that removing selected pane from StackContainer doesn't call resize on that pane, refs #9971

comment:9 Changed 9 years ago by bill

Milestone: 1.71.5
Resolution: worksforme
Status: closedreopened

Oh actually, when it's the selected child being removed, then the bug does occur for me in 1.4, but it's fixed in 1.5

comment:10 Changed 9 years ago by bill

Resolution: fixed
Status: reopenedclosed
Note: See TracTickets for help on using tickets.