Changes between Initial Version and Version 1 of Ticket #9968


Ignore:
Timestamp:
Sep 26, 2009, 12:51:49 AM (10 years ago)
Author:
bill
Comment:

I see that the documentation for onReset does mention reset() calling onReset(), as you talked about:

onReset: function(/*Event?*/ e){
	// summary:
	//		Callback when user resets the form. This method is intended
	//		to be over-ridden. When the `reset` method is called
	//		programmatically, the return value from `onReset` is used
	//		to compute whether or not resetting should proceed
	// tags:
	//		callback
	return true; // Boolean
},

But, it doesn't seem like programatically calling reset() *should* call onReset(), because onReset() is meant for stopping users from resetting a form in the same way that onSubmit() is meant to stop users from sending a form. (But we don't want to stop developers from resetting a form.) Maybe it's just the documentation for onReset() that's incorrect?

Anyway, it's worth some thought.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #9968

    • Property Owner anonymous deleted
    • Property Milestone changed from tbd to 1.5
    • Property Component changed from General to Dijit
    • Property Summary changed from In dijit.form.Form "reset()" method does not call "onReset" event to Form: "reset()" method does not call "onReset" event
  • Ticket #9968 – Description

    initial v1  
    1 In dijit.form.Form, it seems that calling programmatically the reset method does not call the onRest() event.
     1In dijit.form.Form, it seems that calling programmatically the reset method does not call the onReset() event.
    22
    33I see in dijit.form._FormMixin :