Changes between Initial Version and Version 1 of Ticket #9958


Ignore:
Timestamp:
Sep 25, 2009, 11:28:39 AM (12 years ago)
Author:
bill
Comment:

Interesting. I don't understand why this would change the performance. You are still doing the same number of replaceChild() calls, aren't you? Just at a different time?

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #9958 – Description

    initial v1  
    1212In the create method, line 393, I replaced :
    1313
     14{{{
     15#!js
    1416if(source && source.parentNode){       
    1517    source.parentNode.replaceChild(this.domNode, source);
    1618}
     19}}}
    1720
    1821by
    1922
     23{{{
     24#!js
    2025if(source && source.parentNode){
    2126  if(this.groupReplacement){
     
    2530  }
    2631}
     32}}}
    2733
    2834I also replaced :
    2935
     36{{{
     37#!js
    3038if(this.srcNodeRef && !this.srcNodeRef.parentNode){
    3139  delete this.srcNodeRef;
    3240}
    33 
     41}}}
    3442
    3543by
    3644
     45{{{
     46#!js
    3747if(!this.groupRendering){
    3848  if(this.srcNodeRef && !this.srcNodeRef.parentNode){
     
    4050  }
    4151}
     52}}}
    4253
    4354And at the end of my page, I call a js function that processes my arrays to do the replacements and the delete if needed, for all items. So I can configure all my widgets individually to work this way. As far as I tested, only Button linked to a menu doesn't allow this because a dom search is done when their mutual reference is processed.