Opened 10 years ago

Closed 6 years ago

#9957 closed enhancement (wontfix)

[patch] [ccla] provide xhrargs for QueryReadStore

Reported by: percious Owned by: wolfram
Priority: high Milestone: future
Component: DojoX Data Version: 1.3.2
Keywords: Cc:
Blocked By: Blocking:

Description

This patch provides a new variable for QRS: xhrargs. The xhargs are mixin'd with the args generated by the regular querying method before the xhr request is sent. This is needed for folks who want to provide preventCache setting to their xhr calls within QRS. This is currently implemented in tw.dojo (a python wrapper for Dojo)

Attachments (4)

qrs_xhrargs.2.diff​ (1.2 KB) - added by percious 10 years ago.
qrs_xhrargs.3.diff​ (1.1 KB) - added by percious 10 years ago.
qrs_xhrargs.diff​ (1.1 KB) - added by percious 10 years ago.
9957_xhrargs_xhrfunc.diff​ (2.7 KB) - added by Robert Coup 10 years ago.
Updated patch to [20681], includes tests and allows overriding IO function via xhrFunc argument.

Download all attachments as: .zip

Change History (8)

Changed 10 years ago by percious

Attachment: qrs_xhrargs.2.diff​ added

Changed 10 years ago by percious

Attachment: qrs_xhrargs.3.diff​ added

Changed 10 years ago by percious

Attachment: qrs_xhrargs.diff​ added

comment:1 Changed 10 years ago by Jared Jurkiewicz

Owner: changed from Jared Jurkiewicz to wolfram

comment:2 Changed 10 years ago by bill

Milestone: tbd → future
Summary: patch: provide xhrargs for QueryReadStore → [patch] [no cla] provide xhrargs for QueryReadStore

Hi Chris, please file a CLA from ​http://dojofoundation.org/cla/.

Changed 10 years ago by Robert Coup

Attachment: 9957_xhrargs_xhrfunc.diff​ added

Updated patch to [20681], includes tests and allows overriding IO function via xhrFunc argument.

comment:3 Changed 10 years ago by Robert Coup

Summary: [patch] [no cla] provide xhrargs for QueryReadStore → [patch] [ccla] provide xhrargs for QueryReadStore

9957_xhrargs_xhrfunc.diff​ is a rework of Chris' patch:

  • specifying xhrArgs
  • specifying xhrFunc so people can use dojo.io.script or other fun things to access their stores. Only a single function can be passed (same is used for both post & get).
  • unit tests for the above.

I'm happy to commit it, but QueryReadStore isn't my area of expertise, so I'd appreciate a quick review.

comment:4 Changed 6 years ago by bill

Resolution: → wontfix
Status: new → closed

Because dojo.data in general is deprecated in favor of dojo.store (with QueryReadStore sort-of replaced by dojo/store/JsonRest)

Note: See TracTickets for help on using tickets.