dijit.Editor throws errors on FF3 if Editor is hidden in accordian pane on startup

[Jared Jurkiewicz]

dijit.Editor throws errors on FF3 if Editor is hidden in accordian pane on startup

This can easily be seen with:

​http://archive.dojotoolkit.org/nightly/dojotoolkit/dojox/editor/tests/editorPrettyPrint.html

When it loads.

This is because since the doc is hidden, the queryCommand* functions all fail (throw exception).

Easy fix for this is to squetch the errors, as the queryCommands all rerun when it's brought into view, clicked on, etc, anyway.

Patch forthhcoming.

Bill, You okay with this?

[Jared Jurkiewicz]

Simple patch.

[bill]

I'm OK with it although the alternative is that when the Editor is the child of a layout container, to defer running that initialization code until the editor is shown (at which point Editor.resize() gets called).

var parent = dijit._Contained.prototype.getParent.call(this);
if(parent && parent.isLayoutContainer){
   // i'm the child of a layout widget....
   // defer initialization until resize() is called
   ...
}

You said those methods are all rerun when the editor is brought into view? How does the editor detect being brought into view?

[Jared Jurkiewicz]

Any clicks on editor generate a onNormalizedDisplayChange event, and that drives a state checking of all the icons. so any interactions with the editor drive it rechecking what should (or shouldn't) be enabled.

[Jared Jurkiewicz]

(In [20223]) Minor tweak to editor, fixes FF3 corner case on errors thrown when hidden. \!strict fixes #9949