Changes between Version 2 and Version 5 of Ticket #9945

Jul 24, 2010, 10:00:04 PM (12 years ago)

(In [22555]) Convert _DateTimeTextBox to extend _HasDropDown, so it gets an icon (down arrow button) to open the drop down. The icon's display is controlled by a hasDownArrow parameter, same as ComboBox.

Tabbing into the widget no longer causes the drop down to (automatically) open. Clicking the field causes the drop to open, although that behavior can be disabled by setting the new "openOnClick" parameter to false. Of course, clicking the down arrow button (if it's displayed) will always open the drop down.

Changed _HasDropDown to not expect the drop down widget (this.dropDown) to exist initially, prior to the user clicking the down arrow, as DateTextBox creates it on demand. Also fixed the connections for the key handlers, which should clearly be on this.focusNode rather than this._buttonNode.

Had to modify _TimePicker some because the handleKey() callback from _HasDropDown is being called on keyup rather than keypress like before, so evt.charOrCode isn't set. Maybe _HasDropDown should be monitoring keypress rather than keyup.

Made a new DropDownBox.html template used for DateTextBox/TimeTextBox, and expected to be used for ComboBox/FilteringSelect once I get those converted to extend _HasDropDown.

Open issues include:

  • confirm aria roles are correct
  • mouseover of the fields in the _TimePicker no longer makes them expand in width
  • TimeTextBox needs more tests

Fixes #5151, refs #9945 !strict.


  • Ticket #9945

    • Property Owner changed from Nathan Toone to bill
    • Property Status changed from new to assigned
    • Property Milestone changed from future to 1.6
  • Ticket #9945 – Description

    v2 v5  
    11The following widgets should be migrated to use the common _HasDropDown code:
    3 1 - dijit.form.!ComboBox[[BR]]
    4 2 - dijit.form.!FilteringSelect (extends from !ComboBox)[[BR]]
    5 3 - dijit.form._DateTimeTextBox[[BR]]
    6 4 - dijit.form.!DateTextBox (extends from _DateTimeTextBox)[[BR]]
    7 5 - dijit.form.!TimeTextBox (extends from _DateTimeTextBox)[[BR]]
     3 1. dijit.form.!ComboBox
     4 2. dijit.form.!FilteringSelect (extends from !ComboBox)
     5 3. dijit.form._DateTimeTextBox
     6 4. dijit.form.!DateTextBox (extends from _DateTimeTextBox)
     7 5. dijit.form.!TimeTextBox (extends from _DateTimeTextBox)