Opened 10 years ago

Closed 9 years ago

#9919 closed enhancement (duplicate)

Implement swipe-select for cells

Reported by: Adam Peller Owned by: evan
Priority: high Milestone: future
Component: DojoX Grid Version: 1.3.2
Keywords: EnhancedGrid Cc: David Schwartz, Bryan Forbes, Nathan Toone
Blocked By: Blocking:

Description

Should be able to click-drag in the grid. Right now, enhanced grid supports this only on the headers. Should this be a feature on the base grid or some sort of mix-in? or just in the enhanced grid?

Refs #9287

Change History (14)

comment:1 Changed 10 years ago by Adam Peller

Cc: drschwarz added
Owner: changed from drschwarz to Evan
Type: defectenhancement

comment:2 Changed 10 years ago by David Schwartz

I'm not quite sure what 'Should be able to click-drag in the grid.' means. Please elaborate. RE your comment 'Swipe select currently works from headers only and not from cells.', cell selection is not yet supported. Swipe select can be used to select those units that are currently supported (columns and rows).

comment:3 Changed 10 years ago by Adam Peller

Click+drag in the grid should select cells, much like it does on column/row headers. I figured that what swipe select means. I would personally find it more intuitive if click+drag on row/column headers were used to move the rows/columns rather than select them.

comment:4 Changed 10 years ago by bill

I'm having trouble understanding this ticket too. Sounds like by "click-drag" you are really talking about selecting via swipe, rather than clicking or dragging. Dragging (w.r.t. Grid) refers to reordering.

As for dragging columns to reorder them, that's already supported in standard grid, see http://download.dojotoolkit.org/release-1.3.2/dojo-release-1.3.2/dojox/grid/tests/test_grid_column_reorder.html.

As for reordering rows by dragging them, we had a long discussion about that and decided that since dojo.data() has no API related to ordering of rows, that the best we could support would be some callback from Grid notifying that the rows had been moved. Although it's unclear if that feature is useful people.

As for selecting, looking at http://archive.dojotoolkit.org/nightly/dojotoolkit/dojox/grid/tests/enhanced/test_enhanced_grid.html selecting rows via swipe is working fine for me. Selecting columns via swipe is also working fine (at least it highlights them). The only missing feature is selecting a region of cells (ie, a certain set of columns in a certain set of rows), which I believe was deferred because it was unclear that anyone needed it.

comment:5 Changed 10 years ago by Adam Peller

Cc: Bryan Forbes Nathan Toone added

I meant drag the mouse. I expect that if I "click" over a cell and then "drag" the mouse it would select a range of cells. Plain and simple. That's what I meant by this ticket. We can call that "swipe select" over cells if that means something to you guys. Right now, swipe select only works on row/column headers. I'd expect it to work in the cells also... I think that functionality is even more basic and may belong in the base grid.

comment:6 Changed 10 years ago by Adam Peller

Summary: Implement "swipe select" in gridImplement swipe-select for cells

comment:7 Changed 10 years ago by Nathan Toone

I think this should be a mixin - or in EnhancedDataGrid?...what you are talking about is "Spreadsheet-style" selection. The base grid is not intended to be a spreadsheet.

comment:8 Changed 10 years ago by bill

Ditto from me...

The reason that I don't want this as default behavior is that it changes the mouse actions (that I think) users are expecting for both drag of table rows (ex: dropping a mail message into a folder, as seen on yahoo mail, thunderbird, etc), and with reordering of columns. It's still possible to do those things, by selecting the row first via the checkbox but thats different than the standard feel for tables in UI's, and also different than how dragging works in other widgets like Tree. (BTW I can't figure out how to reorder columns)

Anyway, none of that is related to swipe-select for cells pe se, but rather the swipe-select feature in general.

comment:9 Changed 10 years ago by David Schwartz

FWIW, CTRL+ drag is a standard shortcut for COPYING objects, not selecting them. CTRL+click is a standard binding for adding non-contiguous objects to a selected set. Also, cell selection is indeed of interest to a variety of IBM product groups and will be implemented as a plugin feature (as will all of our future enhancements).

comment:10 Changed 10 years ago by Nathan Toone

Milestone: tbdfuture

Moving these grid bugs to future.

comment:11 Changed 10 years ago by Adam Peller

Cc: David Schwartz added; drschwarz removed

comment:12 Changed 10 years ago by Nathan Toone

Keywords: EnhancedGrid added

comment:13 Changed 9 years ago by bill

Owner: changed from Evan to evan

comment:14 Changed 9 years ago by evan

Resolution: duplicate
Status: newclosed

Addressed in #11722, ref is added there

Note: See TracTickets for help on using tickets.