Opened 10 years ago

Closed 6 years ago

#9905 closed enhancement (wontfix)

Make the type of debugger configurable via djConfig

Reported by: cb1kenobi Owned by: cb1kenobi
Priority: low Milestone: future
Component: Core Version: 1.3.2
Keywords: debug firebug needsreview Cc: Mike Wilcox
Blocked By: Blocking:

Description

Firebug Lite is hard coded into hostenv_browser.js and should be a config setting. It will also allow other debuggers to be used. This will eliminate the need for the useCustomLogger.

I propose the name of this new config setting should be "debugModule". We can't use "debugger" since it is a reserved word of sorts in certain browsers.

The default value of "debugModule" would be "dojo._Firebug.firebug" so that we don't break backwards compatibility.

Attached is a patch that will add this setting.

Attachments (1)

debugModule.patch (1.9 KB) - added by cb1kenobi 10 years ago.

Download all attachments as: .zip

Change History (6)

Changed 10 years ago by cb1kenobi

Attachment: debugModule.patch added

comment:1 Changed 10 years ago by James Burke

Patch is fine, but I suggest adding docs to the debugModule djConfig option that instructs that any debug module should only deal with console.* methods and not introduce any new methods. Otherwise bad things will happen.

comment:2 Changed 10 years ago by James Burke

Milestone: 1.4future
Owner: changed from James Burke to cb1kenobi

cb1kenobi, if you want to push the patch, feel free to do so, noting the caveats above in any documentation. Putting this as future, but you can push it for 1.4 if you want to get it in on time.

comment:3 Changed 10 years ago by cb1kenobi

I want to hold off on this until I can do some more hacking to figure out if this is the best direction to take. We may need to do a few extra steps that this patch does not include.

comment:4 Changed 8 years ago by ben hockey

Keywords: needsreview added
Priority: highlow

comment:5 Changed 6 years ago by Kitson Kelly

Resolution: wontfix
Status: newclosed

This is just a languishing ticket that needs to be closed.

Note: See TracTickets for help on using tickets.