Opened 10 years ago

Closed 10 years ago

#9899 closed defect (fixed)

dijit.WidgetSet - missing this._hash arg in every() and some()

Reported by: Les Owned by: bill
Priority: high Milestone: 1.4
Component: Dijit Version: 1.3.2
Keywords: dijit.WidgetSet Cc:
Blocked By: Blocking:

Description

I added this._hash as the last argument in the callback call. This argument should also be added in some() to make the calls consistent with dojo.every() and dojo.some() and the rest of the WidgetSet? api.

every: function(func, thisObj){
	var x = 0, i;
	for(i in this._hash){
		if(!func.call(thisObj || dojo.global, this._hash[i], x++, this._hash)){
			return false; // Boolean
		}
	}
	return true; // Boolean 
}

Change History (2)

comment:1 Changed 10 years ago by bill

Milestone: tbd1.4
Owner: set to bill
Status: newassigned

comment:2 Changed 10 years ago by bill

Resolution: fixed
Status: assignedclosed

(In [20121]) Dijit performance optimizations, albeit at the cost of some code size increase, from Les Szklanny (CLA on file), thanks! Fixes #9899, #9900. !strict

Note: See TracTickets for help on using tickets.