Opened 10 years ago
Closed 6 years ago
#9874 closed defect (invalid)
[patch][cla]ComboBox Grid Cell does not close popup when editing is cancelled
| Reported by: | dstarke | Owned by: | dstarke |
|---|---|---|---|
| Priority: | high | Milestone: | future |
| Component: | DojoX Grid | Version: | 1.3.2 |
| Keywords: | Cc: | bill | |
| Blocked By: | Blocking: |
Description
When editing a grid cell using a dojox.grid.cells.ComboBox? editor, if the popup is open when cell editing is cancelled (as with the ESC key), the popup stays visible on the screen.
I have a patch which I will attach to this bug.
Attachments (1)
Change History (9)
Changed 10 years ago by
| Attachment: | comboBoxGridCellCancelPatch.diff added |
|---|
comment:1 follow-up: 2 Changed 10 years ago by
| Milestone: | tbd → 1.5 |
|---|---|
| Owner: | changed from Bryan Forbes to Nathan Toone |
| Summary: | ComboBox Grid Cell does not close popup when editing is cancelled → [patch]ComboBox Grid Cell does not close popup when editing is cancelled |
Have you signed a CLA?
comment:2 Changed 10 years ago by
comment:3 Changed 10 years ago by
| Summary: | [patch]ComboBox Grid Cell does not close popup when editing is cancelled → [patch][cla]ComboBox Grid Cell does not close popup when editing is cancelled |
|---|
comment:4 Changed 9 years ago by
| Milestone: | 1.5 → future |
|---|---|
| Owner: | Nathan Toone deleted |
Moving my tickets to future, as I am not currently working on them.
comment:5 Changed 6 years ago by
| Cc: | bill added |
|---|
Bill, does this fall into the Grid deprecation ticket bucket?
comment:6 Changed 6 years ago by
I closed the other grid tickets as patchwelcome, but can't do that here since it has a patch. You want to close them all as wontfix?
comment:7 Changed 6 years ago by
| Owner: | set to dstarke |
|---|---|
| Status: | new → pending |
dstarke, if you are still interested in this patch, if you could revise it so it applies cleanly to trunk, plus any modifications to the test cases as appropriate, we can get it applied.
comment:8 Changed 6 years ago by
| Resolution: | → invalid |
|---|---|
| Status: | pending → closed |
Because we get so many tickets, we often need to return them to the initial reporter for more information. If that person does not reply within 14 days, the ticket will automatically be closed, and that has happened in this case. If you still are interested in pursuing this issue, feel free to add a comment with the requested information and we will be happy to reopen the ticket if it is still valid. Thanks!
Patch for dojox/grid/cells/dijit.js