Opened 11 years ago

Closed 10 years ago

#9815 closed defect (fixed)

Bounding box not updated correctly by SVG/Silverlight renderers

Reported by: dinkypumpkin Owned by: Eugene Lazutkin
Priority: high Milestone: 1.4.1
Component: DojoX GFX Version: 1.3.2
Keywords: Cc:
Blocked By: Blocking:

Description

The override of dojox.gfx.Shape.setShape() in SVG render omits reset of bbox instance variable. Subsequent calls to getBoundingBox() for simple shapes returns bounding box at shape creation time. Typo in dojo.gfx.Polyline.setShape() in SVG and Silverlight renderers causes same problem. Patches are attached, along with patch to test_tbbox.html to exercise them.

Attachments (3)

dojox-gfx-tests-test_tbbox.html.patch​ (1.1 KB) - added by dinkypumpkin 11 years ago.
dojox-gfx-svg.js.patch​ (591 bytes) - added by dinkypumpkin 11 years ago.
dojox-gfx-silverlight.js.patch​ (439 bytes) - added by dinkypumpkin 11 years ago.

Download all attachments as: .zip

Change History (8)

Changed 11 years ago by dinkypumpkin

Attachment: dojox-gfx-tests-test_tbbox.html.patch​ added

Changed 11 years ago by dinkypumpkin

Attachment: dojox-gfx-svg.js.patch​ added

Changed 11 years ago by dinkypumpkin

Attachment: dojox-gfx-silverlight.js.patch​ added

comment:1 Changed 10 years ago by Eugene Lazutkin

Milestone: tbd → 1.4.1
Priority: normal → high
Status: new → assigned

comment:2 Changed 10 years ago by Eugene Lazutkin

Resolution: → fixed
Status: assigned → closed

(In [21167]) gfx: typo fixes, thx dinkypumpkin!, !strict, fixes #9815.

comment:3 Changed 10 years ago by Adam Peller

Resolution: fixed
Status: closed → reopened

does not appear to be applied to 1.4 branch

comment:4 Changed 10 years ago by Eugene Lazutkin

(In [21195]) dojox.gfx: copying fixes to 1.4.x branch, !strict, refs #10345, refs #9815, refs #9858, refs #10353, refs #10632.

comment:5 Changed 10 years ago by Eugene Lazutkin

Resolution: → fixed
Status: reopened → closed

thx Adam for spotting the problem!

Note: See TracTickets for help on using tickets.