Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#9807 closed enhancement (fixed)

[PATCH][CCLA]: Add in a prettyPrint and entity character handler into dojox.html.

Reported by: Jared Jurkiewicz Owned by: Jared Jurkiewicz
Priority: high Milestone: 1.4
Component: General Version: 1.3.2
Keywords: Cc:
Blocked By: Blocking:

Description

Add in a prettyPrint and entity character handler into dojox.html.

These two functions are necessary to build formatted output from dijit.Editor as well as for formatting demo code on campus. Both also have general use applications.

I have an impl, will be attaching a patch

Attachments (1)

formatter.patch​ (33.3 KB) - added by Jared Jurkiewicz 11 years ago.
Improved formatter again, slight perf boost with string handling in large docs.

Download all attachments as: .zip

Change History (18)

Changed 11 years ago by Jared Jurkiewicz

Attachment: formatter.patch​ added

Improved formatter again, slight perf boost with string handling in large docs.

comment:1 Changed 11 years ago by Jared Jurkiewicz

(In [20001]) Add in the HTML 'prettyPrint' formatter and entity character code to dojox. refs #9807

comment:2 Changed 11 years ago by Jared Jurkiewicz

(In [20013]) Fixing an issue with inline tags. Breaking to new lines can corrupt text for styling tags, so need to not do that specifically for those. refs #9807

comment:3 Changed 11 years ago by Jared Jurkiewicz

(In [20015]) Keep comment nodes if possible. Sometimes IE removes them. Works fine on all other browsers, though. refs #9807

comment:4 Changed 11 years ago by Jared Jurkiewicz

(In [20016]) Left an accidental decode in the text while working on the comment support. Didn't mean to. refs #9807

comment:5 Changed 11 years ago by Jared Jurkiewicz

(In [20017]) AND I left two console.logs in. I'm an idiot. refs #9807

comment:6 Changed 11 years ago by Jared Jurkiewicz

(In [20023]) Wasn't actually using the custom encoding map. Added test for it. refs #9807

comment:7 Changed 11 years ago by Jared Jurkiewicz

Resolution: → fixed
Status: new → closed

Closing as I think I've hit all the current major issues...

comment:8 Changed 11 years ago by Jared Jurkiewicz

(In [20180]) Adding in support for doing 'xhtml' output as well as sorting styles and sorting attributes. refs #9807

comment:9 Changed 11 years ago by Jared Jurkiewicz

(In [20181]) Clean up tabbing. refs #9807

comment:10 Changed 11 years ago by Jared Jurkiewicz

(In [20251]) Add in performance tests along with perf improvement to prettyPrint. refs #9807

comment:11 Changed 11 years ago by Jared Jurkiewicz

(In [20252]) Trailing comma in test file. refs #9807

comment:12 Changed 11 years ago by Jared Jurkiewicz

(In [20256]) Converted regexp to a literal. refs #9807

comment:13 Changed 11 years ago by Jared Jurkiewicz

(In [20311]) Performance tweaks to encode/decode, mainly caching of generated regexp. refs #9807

comment:14 Changed 11 years ago by Jared Jurkiewicz

(In [20380]) Adjust fixes for IE. refs #9807

comment:15 Changed 11 years ago by Jared Jurkiewicz

(In [20436]) Fixing up HTML output a bit more. Not flattening all of CSS to avoid breaking Font Name and such, alsofixed IE malformed DOM handling a bit more. refs #9807

comment:16 Changed 11 years ago by Jared Jurkiewicz

(In [20459]) Optimize when pretty-printing actually occurs. It's not efficient to do it for internal calls, only for when a user is actually extracting the contents. refs #9807

comment:17 Changed 11 years ago by Jared Jurkiewicz

(In [20585]) Fixing empty style removal. refs #9807

Note: See TracTickets for help on using tickets.