Opened 10 years ago
Closed 10 years ago
#9797 closed enhancement (fixed)
[patch] [cla] Add Target option to LinkDialog plugin for Dijit.Editor
| Reported by: | Nicholas VanderPyle | Owned by: | Jared Jurkiewicz |
|---|---|---|---|
| Priority: | high | Milestone: | 1.4 |
| Component: | Editor | Version: | 1.3.2 |
| Keywords: | dijit editor plugin link dialog target | Cc: | Jared Jurkiewicz |
| Blocked By: | Blocking: |
Description (last modified by )
All links in Dijit.Editor use the default link target behavior. It would be nice to have an option to change the target.
I've added a Target dropdown to the LinkDialog.js plugin and attached a patch.
It appears that the file is reused for InsertImage? plugin. The patch that I've attached will also show the Target dropdown when editing an image url, too.
The text in the target dropdown isn't internationalized or pulled from an NLS.
Attachments (2)
Change History (9)
Changed 10 years ago by
| Attachment: | AddLinkDialogTargetPatch.txt added |
|---|
comment:1 Changed 10 years ago by
| Summary: | Add Target option to LinkDialog plugin for Dijit.Editor → [patch] [no cla] Add Target option to LinkDialog plugin for Dijit.Editor |
|---|
We can't look at patches unless you file a CLA, see http://dojofoundation.org/cla/, thanks. (I don't see your name under http://dojotoolkit.org/dojo-contributors)
comment:2 Changed 10 years ago by
I received confirmation for my signed CLA before submitting the ticket. I just just updated my full name in the LDAP Entry of dojotoolkit.org and on the Preferences page here. Where should I go to change my name name under this account so that it reflects the one listed on the CLA site?
comment:3 Changed 10 years ago by
| Description: | modified (diff) |
|---|---|
| Summary: | [patch] [no cla] Add Target option to LinkDialog plugin for Dijit.Editor → [patch] [cla] Add Target option to LinkDialog plugin for Dijit.Editor |
Oh OK great, your name should be added to the list automatically, just hasn't happened yet.
comment:4 Changed 10 years ago by
| Cc: | Jared Jurkiewicz added |
|---|
comment:5 Changed 10 years ago by
| Milestone: | tbd → 1.4 |
|---|
Jared, can you grab this one? I guess we need to internationalize the text, and probably it should just use dijit.form.Select not dijit.form.FilteringSelect?.
comment:6 Changed 10 years ago by
| Owner: | set to Jared Jurkiewicz |
|---|
Changed 10 years ago by
| Attachment: | Linkdialog.patch added |
|---|
Cleanup of LinkDialog?? that makes image support a subclass/separate plugin that extends from img. Made the code a fair bit cleaner (no more needing to check tag names here and here and change attrs.
comment:7 Changed 10 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
(In [20228]) Minor enhancement to LinkDialog?. Improved the code structure too, made it more extentable. fixes #9797
Patch created from Subclipse in Aptana to add Target option to the LinkDialog?.