Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#9785 closed enhancement (fixed)

[PATCH][CCLA] Provide 'NewPage' plugin for Editor

Reported by: Jared Jurkiewicz Owned by: Jared Jurkiewicz
Priority: high Milestone: 1.4
Component: Editor Version: 1.3.2
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by Jared Jurkiewicz)

Next in the series of plugins I've been working on for Editor. This is one for adding a 'NewPage?' button to the toolbar. This plugin is not much code and implements clearing the editor contents to a new 'empty' page.



The NewPage? Plugin provides the following:
1.) New Page support for FireFox? 2, 3, 3.5, Safari 3+, Chrome 2+, Opera 9.6+. Meaning when pressed, it clears the current editor contents.
2.) Icon for NewPage? button (enabled and disabled).
3.) When pressed, it changes the content of the editor to '<br>', a clean newline.

Notes:


Included is a basic test for NewPage?, along with doh.robot invoker

The CSS and NLS 'Command' are in separate files currently to make this easy to test standalone, but if accepted, these should be merged into the base editor ones (which I'll do once you're happy with it).

Browsers I've tested on during its development have been: FireFox? 2, FireFox? 3, FireFox? 3.5, Opera 9.6, Internet Explorer 7.0, 6.0, and 8.0, as well as Safari 3.2.3 and Chrome 2.0.

I'd like to get this into Dojo 1.4.

Attachments (1)

Editor_NewPage.zip (6.0 KB) - added by Jared Jurkiewicz 10 years ago.
Updated newpage plugin

Download all attachments as: .zip

Change History (7)

comment:1 Changed 10 years ago by Jared Jurkiewicz

Description: modified (diff)

Changed 10 years ago by Jared Jurkiewicz

Attachment: Editor_NewPage.zip added

Updated newpage plugin

comment:2 Changed 10 years ago by liucougar

sounds like reset of the editor

I suggest exposing the empty value as an option, which is by default "<br>"

comment:3 Changed 10 years ago by bill

Component: GeneralEditor

I thought at least on FF we used &nbsp; as the empty value, to work around FF bugs, but that's handled in the editor itself IIRC so that it's masked from users (who are likely to just call attr("value", "")).

comment:4 Changed 10 years ago by bill

Milestone: tbd1.4
Owner: changed from bill to Jared Jurkiewicz

See my comments about the Print plugin. Looks good otherwise.

comment:5 Changed 10 years ago by Jared Jurkiewicz

Resolution: fixed
Status: newclosed

(In [20075]) Addning in new page plugin + merged icons + doh.robot tests. fixes #9785

comment:6 Changed 10 years ago by Jared Jurkiewicz

(In [20076]) Forgot to SVN add the actual plugin! Sad. refs #9785

Note: See TracTickets for help on using tickets.