#9783 closed defect (fixed)
dijit._Widget, nodesWithKeyClick, ondijitclick
Reported by: | holgerthurow | Owned by: | Becky Gibson |
---|---|---|---|
Priority: | high | Milestone: | 1.5 |
Component: | Accessibility | Version: | 1.3.2 |
Keywords: | dijit._Widget, nodesWithKeyClick, ondijitclick | Cc: | |
Blocked By: | Blocking: |
Description
Maybe there is a small bug in in dijit._Widget: After defining in line 853
nodesWithKeyClick: ["input", "button"],
there is in line 884 the condition
if(!this.nodesWithKeyClick[obj.nodeName]){
but nodesWithKeyClick was declared as an array, not an object. Further obj.nodeName has to be in lower case to match nodesWithKeyClick, but in FF 3, OS X it is in upper case, e. g. "INPUT".
Change History (7)
comment:1 Changed 11 years ago by
Component: | Dijit → Accessibility |
---|---|
Owner: | set to Becky Gibson |
comment:2 Changed 11 years ago by
Milestone: | tbd → 1.4 |
---|
comment:3 Changed 11 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
nodesWithKeyClick is declared as part of the widget object, thus it needs to be referenced via this.nodesWithKeyClick. The issue with capitalization was addressed in [17832] so closing as fixed.
comment:4 Changed 11 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Of course nodesWithKeyClick has to be referenced via "this". But, as I see it, this.nodesWithKeyClick is not an "associative array", it is a simple array. It does not have a key named "button". this.nodesWithKeyClick.button is undefined. "button" is the value of frame 1 in the array (this.nodesWithKeyClick[1]).
So I think you have to do something like
dojo.indexOf(this.nodesWithKeyClick, obj.nodeName.toLowerCase()) >= 0
comment:5 Changed 11 years ago by
Milestone: | 1.4 → tbd |
---|
comment:6 Changed 11 years ago by
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
comment:7 Changed 11 years ago by
Milestone: | tbd → 1.5 |
---|
Hmm, that does look wrong. Becky?