dijit._Widget, nodesWithKeyClick, ondijitclick

[holgerthurow]

Maybe there is a small bug in in dijit._Widget: After defining in line 853

nodesWithKeyClick: ["input", "button"],

there is in line 884 the condition

if(!this.nodesWithKeyClick[obj.nodeName]){

but nodesWithKeyClick was declared as an array, not an object. Further obj.nodeName has to be in lower case to match nodesWithKeyClick, but in FF 3, OS X it is in upper case, e. g. "INPUT".

[bill]

Hmm, that does look wrong. Becky?

[Becky Gibson]

nodesWithKeyClick is declared as part of the widget object, thus it needs to be referenced via this.nodesWithKeyClick. The issue with capitalization was addressed in [17832] so closing as fixed.

[holgerthurow]

Of course nodesWithKeyClick has to be referenced via "this". But, as I see it, this.nodesWithKeyClick is not an "associative array", it is a simple array. It does not have a key named "button". this.nodesWithKeyClick.button is undefined. "button" is the value of frame 1 in the array (this.nodesWithKeyClick[1]).

So I think you have to do something like

dojo.indexOf(this.nodesWithKeyClick, obj.nodeName.toLowerCase()) >= 0

[Becky Gibson]

(In [21733]) fixes #9783 proper referencing of nodesWithKeyClick in connect() !strict