Opened 10 years ago

Closed 7 years ago

#9773 closed task (wontfix)

Shrinksafe incompatible with latest versions of Rhino

Reported by: tlrobinson Owned by: Richard Backhouse
Priority: low Milestone: future
Component: ShrinkSafe Version: 1.3.2
Keywords: needsreview Cc: cjolif
Blocked By: Blocking:

Description

Rhino recently refactored their AST so Shrinksafe is no longer compatible with new versions.

Attachments (1)

rhino_17r3.patch (3.9 KB) - added by Adam Peller 7 years ago.
patch from rbackhouse (IBM, CCLA)

Download all attachments as: .zip

Change History (19)

comment:1 Changed 10 years ago by dante

which versions of Rhino specifically? What are the side effects here? Is it just dying?

comment:2 Changed 10 years ago by Adam Peller

Owner: changed from alex to Richard Backhouse

comment:3 Changed 10 years ago by Richard Backhouse

Rhino has not yet released their AST into a downloadable jar. The latest available version is Rhino 1.7R2. AST is expected in 1.7R3.

comment:4 Changed 10 years ago by Adam Peller

Don't know when 1.7R3 is, and we can't be future-proof, but if there's anything obvious we can do in our 1.4 release for compatibility, that would be great. I'm guessing we might want to make significant changes to Rhino once the AST is out.

comment:5 Changed 10 years ago by Richard Backhouse

The latest from the mozilla.dev.tech.js-engine.rhino newsgroup is :

"My plan has been to wait for a new release until EcmaScript? edition 5 support was complete before releasing, so likely not until Q1 next year. Using a version built from CVS head is probably okay. "

comment:6 Changed 10 years ago by Adam Peller

Resolution: fixed
Status: newclosed

(In [20704]) Add notes to README to explain compatibility issues with Rhino 1.7R3 and beyond. Rhino will be supporting an AST and a rewrite of ShrinkSafe? may be required. Fixes #9773

comment:7 Changed 10 years ago by Adam Peller

Milestone: tbdfuture
Resolution: fixed
Status: closedreopened
Type: defecttask

Leave open as a 'future' task

comment:8 Changed 7 years ago by ben hockey

Keywords: needsreview added
Priority: highlow

comment:9 Changed 7 years ago by bill

Resolution: patchwelcome
Status: reopenedclosed

I think closure will be the compressor of choice going forwards, and we don't have anyone working on shrinksafe, so closing this ticket.

comment:10 Changed 7 years ago by Adam Peller

Milestone: future1.8
Resolution: patchwelcome
Status: closedreopened

comment:11 Changed 7 years ago by Adam Peller

Priority: lowhigh

Changed 7 years ago by Adam Peller

Attachment: rhino_17r3.patch added

patch from rbackhouse (IBM, CCLA)

comment:13 Changed 7 years ago by Adam Peller

Resolution: fixed
Status: reopenedclosed

In [28550]:

Update to Rhino 1.7r3. Thanks, rbackhouse. Fixes #9773

comment:14 Changed 7 years ago by Adam Peller

In [28567]:

Rhino 1.7r3 caused heap errors. backing out r28550, refs #9773

comment:15 Changed 7 years ago by Adam Peller

Cc: cjolif added
Milestone: 1.8future
Resolution: fixed
Status: closedreopened

Sadly, had to back out Richard's changes. The new Rhino seemed to cause intermittent heap memory errors on the main Dojo build script, running the js script itself and sometimes from within shrinksafe (demos). Raising the min/max heap settings didn't seem to help. Had trouble reproducing this locally.

comment:16 Changed 7 years ago by cjolif

Considering we are nearly reaching the 1.8 beta I would suggest delaying any new tentative to update Rhino to a subsequent release.

comment:17 Changed 7 years ago by Adam Peller

Priority: highlow

Christophe -- I already kicked this back into the "future" bucket

comment:18 Changed 7 years ago by bill

Resolution: wontfix
Status: reopenedclosed

Shrinksafe is deprecated in favor of optimization using closure.

Note: See TracTickets for help on using tickets.