Opened 10 years ago
Closed 7 years ago
#9773 closed task (wontfix)
Shrinksafe incompatible with latest versions of Rhino
| Reported by: | tlrobinson | Owned by: | Richard Backhouse |
|---|---|---|---|
| Priority: | low | Milestone: | future |
| Component: | ShrinkSafe | Version: | 1.3.2 |
| Keywords: | needsreview | Cc: | cjolif |
| Blocked By: | Blocking: |
Description
Rhino recently refactored their AST so Shrinksafe is no longer compatible with new versions.
Attachments (1)
Change History (19)
comment:1 Changed 10 years ago by
comment:2 Changed 10 years ago by
| Owner: | changed from alex to Richard Backhouse |
|---|
comment:3 Changed 10 years ago by
Rhino has not yet released their AST into a downloadable jar. The latest available version is Rhino 1.7R2. AST is expected in 1.7R3.
comment:4 Changed 10 years ago by
Don't know when 1.7R3 is, and we can't be future-proof, but if there's anything obvious we can do in our 1.4 release for compatibility, that would be great. I'm guessing we might want to make significant changes to Rhino once the AST is out.
comment:5 Changed 10 years ago by
The latest from the mozilla.dev.tech.js-engine.rhino newsgroup is :
"My plan has been to wait for a new release until EcmaScript? edition 5 support was complete before releasing, so likely not until Q1 next year. Using a version built from CVS head is probably okay. "
comment:6 Changed 10 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
(In [20704]) Add notes to README to explain compatibility issues with Rhino 1.7R3 and beyond. Rhino will be supporting an AST and a rewrite of ShrinkSafe? may be required. Fixes #9773
comment:7 Changed 10 years ago by
| Milestone: | tbd → future |
|---|---|
| Resolution: | fixed |
| Status: | closed → reopened |
| Type: | defect → task |
Leave open as a 'future' task
comment:8 Changed 8 years ago by
| Keywords: | needsreview added |
|---|---|
| Priority: | high → low |
comment:9 Changed 8 years ago by
| Resolution: | → patchwelcome |
|---|---|
| Status: | reopened → closed |
I think closure will be the compressor of choice going forwards, and we don't have anyone working on shrinksafe, so closing this ticket.
comment:10 Changed 8 years ago by
| Milestone: | future → 1.8 |
|---|---|
| Resolution: | patchwelcome |
| Status: | closed → reopened |
comment:11 Changed 8 years ago by
| Priority: | low → high |
|---|
comment:15 Changed 8 years ago by
| Cc: | cjolif added |
|---|---|
| Milestone: | 1.8 → future |
| Resolution: | fixed |
| Status: | closed → reopened |
Sadly, had to back out Richard's changes. The new Rhino seemed to cause intermittent heap memory errors on the main Dojo build script, running the js script itself and sometimes from within shrinksafe (demos). Raising the min/max heap settings didn't seem to help. Had trouble reproducing this locally.
comment:16 Changed 8 years ago by
Considering we are nearly reaching the 1.8 beta I would suggest delaying any new tentative to update Rhino to a subsequent release.
comment:17 Changed 8 years ago by
| Priority: | high → low |
|---|
Christophe -- I already kicked this back into the "future" bucket
comment:18 Changed 7 years ago by
| Resolution: | → wontfix |
|---|---|
| Status: | reopened → closed |
Shrinksafe is deprecated in favor of optimization using closure.
which versions of Rhino specifically? What are the side effects here? Is it just dying?