Opened 13 years ago

Closed 13 years ago

#977 closed defect (worksforme)

FloatingPane IE6 icon problem

Reported by: brett@… Owned by: koranteng
Priority: high Milestone: 0.9
Component: Widgets Version: 0.3
Keywords: FloatingPane icon issue Cc: brett@…
Blocked By: Blocking:

Description

FloatingPane? icon not being hidden when dynamicaly producing a window using javascript in Dojo 0.3.0

I narrowed the issue down to line 80 of the 'src/widget/FloatingPane.js' script that reads:

if(this.iconSrc=="")

I changed it to read:

if(this.iconSrc.length == 0)

and the problem was solved.

Sorry if this is the wrong place to put things like this but I am new.

Change History (7)

comment:1 Changed 13 years ago by bill

Cc: brett@… added

Hi Brett. This is the right to put things like that :-). But aren't those two if statement equivalent?

Also, what browser were you using? Because

http://archive.dojotoolkit.org/nightly/tests/widget/test_FloatingPane.html

works fine for me in IE6 and FF1.5. (Half the windows have icons and the other half don't.)

comment:2 Changed 13 years ago by anonymous

Hi, I think so, here is a snippet of my code that did not work under the other method:

  // Create a new pane to hold the control
  var newNode = document.createElement("div");
  newNode.id    ='window_'+window_id;
  newNode.style.cssText ='width:'+width+'; height:'+height+'; top:40; left:15px;';
  newNode = document.body.appendChild(newNode);

  ajax_uri = ajax_uri+'&windowid=window_'+window_id;
  var newWindow = dojo.widget.createWidget("FloatingPane",
       {id:"window_"+window_id,                                                            
        title:window_label,                                                          
        constrainToContainer:true,                                                           
        hasShadow:true,
        displayCloseAction:true,
        windowState:'normal',
        iconSrc:icon_uri,                                                           
        toggle:'explode',
        templateCssPath: css_uri}, newNode);
   newWindow.wigetId = "window_"+window_id;

The window appeared with the icon in FF1.5 but under IE6 the window appeared but without the icon. The IE DOM viewer said that the icon had a visibility of hidden in IE6. I may have be doing something wrong but I could not fix it any other way.

Thanks for the quick response :-)

Brett

comment:3 Changed 13 years ago by bill

Owner: changed from anonymous to bill
Status: newassigned

comment:4 Changed 13 years ago by dylan

Milestone: 0.5

comment:5 Changed 13 years ago by bill

The code sample you provided references icon_uri but never defines it. Can you give a better testcase?

comment:6 Changed 13 years ago by koranteng

Owner: changed from bill to koranteng
Status: assignednew

comment:7 Changed 13 years ago by koranteng

Resolution: worksforme
Status: newclosed

This works for me on the trunk - all the floatingpane tests are passing. I emailed author and haven't received a response. I'm closing for now but feel free to reopen if necessary

Note: See TracTickets for help on using tickets.