Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#9764 closed defect (fixed)

[patch][cla] dojo._Animation.stop() ignores easing

Reported by: Stefan Schuster Owned by: nic
Priority: high Milestone: 1.4
Component: fx Version: 1.3.2
Keywords: Cc: nic
Blocked By: Blocking:

Description

I don't know wether this is on purpose and I've misunderstood this, but I think it's a bug that dojo._Animation's stop method ignores the easing for the "stop" fire. This leads to a bad jump in the Animation using e.g. dojo.fx.easing.expoOut when calling stop at 90% or so.

I've attached a patch that in my opinion fixes the issue.

Attachments (3)

animStop.patch (484 bytes) - added by Stefan Schuster 10 years ago.
fxAnimStop.html (1.9 KB) - added by Stefan Schuster 10 years ago.
DOH test case
fx.js.patch (1.3 KB) - added by nic 10 years ago.

Download all attachments as: .zip

Change History (12)

Changed 10 years ago by Stefan Schuster

Attachment: animStop.patch added

comment:1 Changed 10 years ago by dante

Cc: nic added
Owner: changed from Bryan Forbes to dante

is there a CLA on file for this patch sschuster? a test case would be awesome. cc'ing nicrizzo who has been on top of Animation things of late.

comment:2 Changed 10 years ago by Stefan Schuster

Yes, I signed a CLA long time ago (just found the email confirmation from 2/23/07). Although this is a formal bug I've recognized that this only is a problem if you use the value you get in onStop, or misuse the curve getValue method to actually apply values.

Changed 10 years ago by Stefan Schuster

Attachment: fxAnimStop.html added

DOH test case

comment:3 Changed 10 years ago by Stefan Schuster

Just added a DOH test case. It's meant to be run from inside dojo/tests (like dojo/tests/fx.html) and shows what I mean based on a plain _Animation object, and once with animateProperty where the value on stop gets used.

comment:4 Changed 10 years ago by dante

Summary: dojo._Animation.stop() ignores easing[patch][cla] dojo._Animation.stop() ignores easing

thanks for the updated info and test.

Changed 10 years ago by nic

Attachment: fx.js.patch added

comment:5 Changed 10 years ago by nic

Same problem in onPlay, onPause and onBegin.
Added a _getStep method to minimize the code

comment:6 Changed 10 years ago by dante

Owner: changed from dante to nic

@nic - take it away. +1 from me.

comment:7 Changed 10 years ago by nic

Status: newassigned

comment:8 Changed 10 years ago by nic

Resolution: fixed
Status: assignedclosed

(In [20185]) fixes #9764 based on the sschuster's patch (thanks!), added a _getStep function to fix onBegin, onPlay and onPause too !strict

comment:9 Changed 10 years ago by bill

Milestone: tbd1.4
Note: See TracTickets for help on using tickets.