Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#9744 closed defect (fixed)

Firebug Lite - better browser checking

Reported by: Mike Wilcox Owned by: Mike Wilcox
Priority: high Milestone: 1.4
Component: Core Version: 1.3.2
Keywords: Cc:
Blocked By: Blocking:

Description

Dojo's Firebug Lite needs to be updated. The fix is to not open it on any browser that has the ability to have a console. This means in Safari 4, IE8 or IE7 compat mode, and Firefox will never show Firebug Lite. All other cases will show it if isDebug = true.

Attachments (1)

firebug.patch (1.9 KB) - added by Mike Wilcox 10 years ago.

Download all attachments as: .zip

Change History (8)

Changed 10 years ago by Mike Wilcox

Attachment: firebug.patch added

comment:1 Changed 10 years ago by Mike Wilcox

Also add fix for IE8's anemic console.

comment:2 Changed 10 years ago by Mike Wilcox

(In [19922]) Refs #9744 - Updated Firebug's browser sniffing. \!strict

comment:3 Changed 10 years ago by Mike Wilcox

(In [19930]) Refs #9744 - Changed the IE closure fix to a non-string closure \!strict

comment:4 Changed 10 years ago by Mike Wilcox

(In [19945]) Refs #9744 - removed the new keyword as per James' suggestion \!strict

comment:5 Changed 10 years ago by Mike Wilcox

Resolution: fixed
Status: newclosed

This seems to be working well. Thought this was closed.

comment:6 Changed 10 years ago by (none)

Milestone: 1.3.3

Milestone 1.3.3 deleted

comment:7 Changed 10 years ago by bill

Milestone: 1.4

we won't have a 1.3.3

Note: See TracTickets for help on using tickets.