Opened 10 years ago

Closed 10 years ago

Last modified 9 years ago

#9724 closed defect (fixed)

dojox.layout.FloatingPane maximize does not set x, y position

Reported by: Philippe May Owned by: dante
Priority: high Milestone: 1.4
Component: DojoX Layout Version: 1.3.2
Keywords: Cc:
Blocked By: Blocking:

Description

The resize function of dojox.layout.FloatingPane? does not set the (top, left) absolute coordinates of the pane when they are equal to 0. This effect is seen mostly when maximizing a pane (since dijit.getViewport() returns {t:0, l:0 ...})

Attachments (1)

patch.diff (248 bytes) - added by Philippe May 10 years ago.
Proposed patch for dojox.layout.FloatingPane?.js

Download all attachments as: .zip

Change History (6)

Changed 10 years ago by Philippe May

Attachment: patch.diff added

Proposed patch for dojox.layout.FloatingPane?.js

comment:1 Changed 10 years ago by Adam Peller

Owner: changed from Adam Peller to dante

comment:2 Changed 10 years ago by dante

Milestone: tbd1.4
Status: newassigned

comment:3 Changed 10 years ago by dante

Resolution: fixed
Status: assignedclosed

(In [20317]) fixes #9724 - adjust the truthyness of the x/y check in floatingpane so 0 works. thanks for spotting this aprilmay. this one is trivial/nobrainer so no CLA required but I should check and see to be certain, I see several other reports for FloatingPane? here

comment:4 Changed 10 years ago by dante

(In [20318]) hm. actually fixes #9724, makes floatingpane use attributeMap for title, deprecates setTitle, fixes #9725 and uses dojo.create over document.createElement. this is some old code.

comment:5 Changed 9 years ago by bill

Component: DojoxDojoX Layout
Note: See TracTickets for help on using tickets.