dojo.html.getElementsByClass doesn't respect the scoping node on firefox

[[email protected]…]

When using dojo.html.getElementsByClass, the scoping node is not respected on firefox (or possibly other browsers that supports document.evaluate). Attached is a patch to test_html.html that repros the problem.

[[email protected]…]

test case patch for test_html.html

[[email protected]…]

Also, I have a CLA on file. Probably under ben AT blowery.org (Ben Lowery)

[bill]

Just fixing (the cryptic) version and milestone fields.

[akaihola]

Here's the fix which was posted as #1079:

change

var xpath = "//" + (nodeType "*") + "[contains(";

to

var xpath = ".//" + (nodeType "*") + "[contains(";

in dojo.html.getElementsByClass

Meanwhile a work-around is to specify true as the fifth (useNonXpath) argument to dojo.html.getElementsByClass(). An example:

dojo.html.getElementsByClass("classname", parent, null, null, true)

instead of the non-functional

dojo.html.getElementsByClass("classname", parent)

[akaihola]

patch verified to work in Firefox 1.5.0.4 and Epiphany 2.14.1.1

[Tom Trenka]

Fixed in the html-refactor.

[(none)]

Milestone 0.4 deleted