Opened 13 years ago
Closed 9 years ago
#9706 closed defect (patchwelcome)
[regression] Reduce measurements in the grid
Reported by: | Kris Zyp | Owned by: | Bryan Forbes |
---|---|---|---|
Priority: | high | Milestone: | 2.0 |
Component: | DojoX Grid | Version: | 1.3.2 |
Keywords: | 14open | Cc: | |
Blocked By: | Blocking: |
Description
One the primary performance bottlenecks for the grid is the extensive measurements that are performed for laying out the rows/cells in the grid. Measurements are extremely expensive operations (because they require the browser to layout the DOM and compute widths and heights). I believe the grid could be much more efficient and fast if these measurements could be reduced.
I am attaching a patch that caches some measurements where possible and introduces a new property on the grid, "rowHeight", which can be used to set a static height for the rows. This property can be set and provide a means for eliminating the need for many of the height measurements that take place during rendering.
Attachments (2)
Change History (16)
Changed 13 years ago by
Attachment: | DataGridFasterMeasurements.patch added |
---|
comment:1 Changed 13 years ago by
comment:2 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:3 Changed 13 years ago by
Milestone: | tbd → 1.4 |
---|
for the unpsychic, this was fixed in [19976]
also, please set milestones on tickets marked as closed.
comment:5 Changed 13 years ago by
@kzyp - no, but sometimes we "lose sync". Always a good idea to doublecheck. You would have received an email presumably showing the resolution change had post-commit done it's work.
comment:6 Changed 13 years ago by
Priority: | normal → high |
---|---|
Resolution: | fixed |
Status: | closed → reopened |
Summary: | Reduce measurements in the grid → [regression] Reduce measurements in the grid |
Type: | enhancement → defect |
I went revision-by-revision and as of [19976], DataGrids? in TabContainers? stopped appearing entirely in Safari 4 and FF 3.5.
- Go to http://archive.dojotoolkit.org/dojo-2009-08-29/dojotoolkit/dojox/grid/tests/robot/_DataGrid.html
- Click the "Markup structure" tab
You do not see a DataGrid? in the tab! IE8 is unaffected by this bug.
comment:8 Changed 12 years ago by
Milestone: | 1.5 → 1.6 |
---|
1.5 is released, moving remaining tickets to 1.6
comment:9 Changed 11 years ago by
Milestone: | 1.6 → future |
---|
(sadly) punting seemingly abandoned ticket and meta tickets to future
comment:10 Changed 11 years ago by
Milestone: | future → 1.7 |
---|
comment:11 Changed 11 years ago by
Priority: | high → normal |
---|
comment:12 Changed 10 years ago by
Milestone: | 1.8 → 2.0 |
---|
1.8 has been tagged; moving all outstanding tickets to next major release milestone.
comment:13 Changed 9 years ago by
comment:14 Changed 9 years ago by
Resolution: | → patchwelcome |
---|---|
Status: | reopened → closed |
Kris, this patch is great. Please go ahead and apply and resolve once it's applied.