Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#9704 closed defect (fixed)

dojox.data.CsvStore doesn't provide an abort() method

Reported by: Stefan Bird Owned by: Jared Jurkiewicz
Priority: high Milestone: 1.4
Component: DojoX Data Version: 1.3.2
Keywords: Cc:
Blocked By: Blocking:

Description

The dojo.data.api.Read fetch() method is supposed to return a request object that has an abort() method. The request object returned by CsvStore? doesn't, and therefore it doesn't fully implement the Read API.

Attachments (1)

CsvStore.patch (2.7 KB) - added by Jared Jurkiewicz 10 years ago.
Patch that improves abort handling.

Download all attachments as: .zip

Change History (4)

comment:1 Changed 10 years ago by Jared Jurkiewicz

It actually does, but the abort function does not appear until after the CsvFile? had been loaded. Similar issue that IFRS had some time ago. The fix is also the same, as they're all based on the simpleFetch pattern and as such can use the same intsertion logic in their _fetchItems implementation to attach on an abort function that will call the xhr cancel if called.

Changed 10 years ago by Jared Jurkiewicz

Attachment: CsvStore.patch added

Patch that improves abort handling.

comment:2 Changed 10 years ago by Jared Jurkiewicz

Resolution: fixed
Status: newclosed

(In [19803]) Minor fix to CsvStore?, same as one made to IFRS some time ago. Also removed unused variable. \!strict fixes #9704

comment:3 Changed 10 years ago by Jared Jurkiewicz

Milestone: tbd1.4
Note: See TracTickets for help on using tickets.