Opened 10 years ago

Closed 10 years ago

Last modified 9 years ago

#9703 closed defect (fixed)

InlineEditBox.DateTextBox does not handle predefined value correctly

Reported by: youngho Owned by: bill
Priority: high Milestone: 1.4
Component: Dijit - Form Version: 1.3.2
Keywords: InlineEditBox DateTextBox Cc:
Blocked By: Blocking:

Description

'Form Letter with predefined values, and no auto-save' test section at dijit/tests/test_InlineEditBox.html,

if you clicked the date '01/01/2007', the popup calendar shows current date not displayed value date.

Attachments (2)

test_inlineEditBox.patch (2.5 KB) - added by youngho 10 years ago.
InlineEditBox.html (5.2 KB) - added by youngho 10 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 10 years ago by bill

Summary: lineEditBox.DateTextBox does not handle predefined value correctlyInlineEditBox.DateTextBox does not handle predefined value correctly

I think this might be a "problem" with the test file, that the displayed value of "01/01/2007" is meaningless for your locale. Are you running this in Korea, and if so what is the proper date format there?

comment:2 Changed 10 years ago by youngho

Yes! you are right.

The test editBox should have editorParams="{constraints: {datePattern: 'MM/dd/yyyy'}}" information.

So this ticket Summary should be changed to 'test_InlineEditBox.html doesn't work properly'

Sorry for bordering you.

I made a robot test for inlineEdit Box display value transfer to the editor object properly.

Changed 10 years ago by youngho

Attachment: test_inlineEditBox.patch added

Changed 10 years ago by youngho

Attachment: InlineEditBox.html added

comment:3 Changed 10 years ago by bill

Milestone: tbd1.4
Owner: set to bill
Status: newassigned

Cool, thanks for the robot test and the test file update; I'll check them in.

comment:4 Changed 10 years ago by bill

Resolution: fixed
Status: assignedclosed

(In [19896]) InlineEditBox? robot test and test file locale fix, courtesy of Youngho (CLA on file), thanks! Fixes #9703.

comment:5 Changed 10 years ago by bill

(In [20261]) Some cleanup of InlineEditBox? test. Shouldn't have robot commands after the Deferred has already been fired. Still needs more cleanup (like using deterministic id's for the buttons), and more importantly, need more tests of actually editing the value and then saving it.

Refs #9703.

comment:6 Changed 10 years ago by bill

(In [20281]) TODO comment about test, refs #9703.

comment:7 Changed 9 years ago by bill

Component: DijitDijit - Form
Note: See TracTickets for help on using tickets.