Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#970 closed defect (invalid)

Compressor bug w/"else if" (affects FishEye code)

Reported by: Eric Owned by: jkuhnert
Priority: high Milestone:
Component: BuildSystem Version: 0.3
Keywords: Cc:
Blocked By: Blocking:

Description

There is a variation in logic in the compressed and uncompressed versions of dojo.js that prevents the Fisheye from properly working on Mozilla. The error is caused the the use of else instead else if in two places in the compressed version.

Uncompressed (working) logic (2 instances):

Line 5792:

else if(document.getBoxObjectFor)

Line 5825:

else if(node["x"]&&node["y"])

Compressed (non-working equivalent logic:

Lines 4202-3:

else {if(document.getBoxObjectFor)

Lines 4230-1:

else {if(node["x"]&&node["y"])

Change History (4)

comment:1 Changed 13 years ago by bill

Component: WidgetsBuildSystem
Milestone: 0.4
Owner: changed from anonymous to alex
Summary: Mozilla FishEye Demo Error, compressed dojo.js onlyCompressor bug w/"else if" (affects FishEye code)

Alex, looks like your territory. changing title etc. to reflect that this is an apparent bug with the compressor.

comment:2 Changed 13 years ago by jkuhnert

Owner: changed from alex to jkuhnert
Status: newassigned

comment:3 Changed 13 years ago by jkuhnert

Resolution: invalid
Status: assignedclosed

Impossible to tell what the original problem was as the line numbers are meaningless without the original dojo.js or dojo.uncompressed.js files. I scanned the fisheye code for these references and they don't appear to exist anymore.. Also just applied a fairly extensive build patch so I'm hoping this is resolved now. Please feel free to re-open this (or a new one with more detail) if it is still happening.

comment:4 Changed 12 years ago by (none)

Milestone: 0.4

Milestone 0.4 deleted

Note: See TracTickets for help on using tickets.