#9699 closed defect (fixed)
scrollIntoView() memory leaks
Reported by: | bill | Owned by: | Douglas Hays |
---|---|---|---|
Priority: | high | Milestone: | 1.4 |
Component: | Dijit | Version: | 1.3.2 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
It's bad to set properties direction on a !DOMNode's JS object, like scrollIntoView() is doing:
element._borderStart = { H:(isIE8strict && !ltr)? (bp.w-bp.l):bp.l, V:bp.t }; element._borderSize = { H:bp.w, V:bp.h }; element._scrolledAmount = { H:element.scrollLeft, V:element.scrollTop }; element._offsetSize = { H: element._offsetWidth||element.offsetWidth, V: element._offsetHeight||element.offsetHeight };
It causes memory leaks on IE if they aren't cleaned up properly, and I think they aren't being cleaned up, or at least they are still around after scrollIntoView() returns. I can see them in DOM explorer on IE7 on the tabStripButton nodes in test_tabContainer.html.
See #9614.
Change History (4)
comment:1 Changed 11 years ago by
Milestone: | tbd → 1.4 |
---|
comment:2 Changed 11 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:4 Changed 11 years ago by
Note: See
TracTickets for help on using
tickets.
(In [19915]) Fixes #9699. References #8456. Refactor scrollIntoView to use the new dojo.position. Remove most browser-specific workarounds. Add support for position:fixed. !strict