Opened 10 years ago

Closed 8 years ago

#9698 closed defect (fixed)

webkitMobile=true with profile=standardCustomBase build causes "d is not defined" runtime error

Reported by: James Burke Owned by: dylan
Priority: low Milestone: 1.7
Component: BuildSystem Version: 1.3.2
Keywords: needsreview Cc:
Blocked By: Blocking:

Description

At least one problem is in _base.html.js:

//>>excludeStart("webkitMobile", kwArgs.webkitMobile);
(function(){
	var d = dojo;
//>>excludeEnd("webkitMobile");

the webkitMobile removes the function() declaration and the var d = dojo declaration. However when a custom build is done with at custom base that only includes the loader, the html.js file needs to work loaded as a standalone file.

To test, do a build with the two build options mentioned in the title, then try to run the Dojo Core DOH tests.

Change History (5)

comment:1 Changed 10 years ago by jasonw22

May also effect _base.NodeList?.js, _base.fx.js, _base.event.js, and _base.xhr.js, and potentially others.

comment:2 Changed 10 years ago by James Burke

Milestone: tbdfuture

comment:3 Changed 9 years ago by Chris Mitchell

Owner: changed from alex to dylan

please review/triage

comment:4 Changed 8 years ago by ben hockey

Keywords: needsreview added
Priority: highlow

comment:5 Changed 8 years ago by bill

Milestone: future1.7
Resolution: fixed
Status: newclosed

That particular problem is fixed but the build pragma itself has outlived it's usefulness. I'll try to replace it with a webkitMobile build profile.

Note: See TracTickets for help on using tickets.