[patch] dojo._getIeDispatcher() doesn't return value.

[yoava]

Problem: dojo._getIeDispatcher() doesn't return value.

Details: This means that when connecting a new event to link like this <a href="..." onclick="return false"/> (which cancels default behavior) causes the link open href onclick (becuase false is not returned). This happens only in IE of course.

Simple Solution: Change dojo._getIeDispatcher as follows:

dojo._getIeDispatcher = function(){[[BR]]
  return new Function('''"return " +''' dojo._scopeName + "._ieDispatcher(arguments, this)");[[BR]]
}

[bill]

You'll need to attach a test case.

[bill]

PS: it sounds like a trivial thing to reproduce but it's just our policy to always ask for test cases attached to the tickets (using the attach file button, available after you create the ticket).

[James Burke]

No test case, closing for now. it is not clear if the report means that

a) <a href="" onclick="return false"> gets another connection via dojo.connect,

or b) if the tag starts out as <a href=""> and there is a dojo.connect(aNode, "onclick", function(evt){return false;});

If b) the proper way to stop it is evt.preventDefault();

Feel free to reopen with a test case.

[bill]

I had hoped yoava would file a test case but I hate to close such a trivial ticket so I caved in and wrote one.

[bill]

test case (put parallel to dojo/) bug is that clicking the second link navigates to dojotoolkit.org on IE

[bill]

The solution is written above (just adding "return" into _getIeDispatcher()). Given the triviality of the change no CLA is needed.

[bill]

Still an issue in 1.7.

[Kitson Kelly]

This appears to now be invalid as _getIeDispatcher is no longer part of the code. I suspect when dojo/_base/connect was rewritten to leverage dojo/on this became obsolete.