Opened 13 years ago
Closed 10 years ago
#9682 closed defect (patchwelcome)
ShrinkSafe obfuscates _ character when it shouldn't
Reported by: | dante | Owned by: | Richard Backhouse |
---|---|---|---|
Priority: | low | Milestone: | future |
Component: | ShrinkSafe | Version: | 1.3.2 |
Keywords: | needsreview | Cc: | |
Blocked By: | Blocking: |
Description
Seems like an edge case, but ShrinkSafe? is improperly replacing a single-character parameter in a function signature with a longer variable. eg:
var foo = function(_, longer){ }
turns into:
var _1 = function(_2, _3){ }
fwiw, passed same sample through YUI Compressor and get:
var a=function(b,c){}
Attachments (1)
Change History (8)
comment:1 Changed 13 years ago by
Changed 13 years ago by
Attachment: | underscore.test.patch added |
---|
unit test failing to meet expectations.
comment:2 Changed 13 years ago by
Owner: | changed from alex to Richard Backhouse |
---|
comment:3 Changed 13 years ago by
Milestone: | tbd → 1.5 |
---|
comment:4 Changed 12 years ago by
Milestone: | 1.5 → 1.6 |
---|
comment:5 Changed 11 years ago by
Milestone: | 1.6 → future |
---|
(sadly) punting seemingly abandoned ticket and meta tickets to future
comment:6 Changed 10 years ago by
Keywords: | needsreview added |
---|
comment:7 Changed 10 years ago by
Resolution: | → patchwelcome |
---|---|
Status: | new → closed |
I think closure will be the compressor of choice going forwards, and we don't have anyone working on shrinksafe, so closing this ticket.
Note: See
TracTickets for help on using
tickets.
note, this only applies to the character "_" for some reason.
becomes