[patch] [cla] CheckedMultiSelect shows RadioButtons instead of CheckBoxes on IE8

[vlad]

on IE8 even if the multiple set to 'true' (or present) for the dojox.form.CheckedMultiSelect?

it still shows radiobuttons instead of checkboxes (and only allows to select one thing instead of multiple).

I am running on the trunk as of today

Using severity critical -- because there is no workaround I can come up with.

[vlad]

demonstrates the problem

[Andre Steenveld]

Patch to make the checked multi select work on IE8

[Andre Steenveld]

I attached a little fix, it appears that instead of "true" IE8 returns "multiple" when it is a multi select list.

[vlad]

thank you, for some reason I do not see anything in the .diff file - could you please reattach the patch.

thank you

[Andre Steenveld]

Patch

[vlad]

thank you, your patch works. I hope maintainers notice that this problem is actually is in the dijit and not dojox as I specified earlier (and therefore more critical to address)

[bill]

I'll take a look at the patch then (thanks for supplying it, Andre!)

[bill]

That's a good local fix to the problem, but I feel like the root issue is that _FormSelectWidget.js is treating "multiple" as a string (and telling the parser to treat it as a string) when it's really a boolean, just like checked or disabled. By changing it to a boolean the code gets simpler and the need for the _multiSelect boolean (which is basically the same as "multiple" is gone.

[bill]

(In [20033]) Simplify code and resolve a bug by treating "multiple" like the boolean that it is, rather than as a string. Fixes #9680 !strict.