Opened 10 years ago

Closed 10 years ago

#9680 closed defect (fixed)

[patch] [cla] CheckedMultiSelect shows RadioButtons instead of CheckBoxes on IE8

Reported by: vlad Owned by: bill
Priority: high Milestone: 1.4
Component: DojoX Form Version: 1.3.2
Keywords: dojox.form, CheckedMultiSelect, IE8, RadioButton, multiple Cc:
Blocked By: Blocking:

Description

on IE8 even if the multiple set to 'true' (or present) for the dojox.form.CheckedMultiSelect?

it still shows radiobuttons instead of checkboxes (and only allows to select one thing instead of multiple).

I am running on the trunk as of today

Using severity critical -- because there is no workaround I can come up with.

Attachments (3)

CheckedMultiSelect_IE8_PROBMLEM_1.html (3.1 KB) - added by vlad 10 years ago.
demonstrates the problem
multiselect.ie.patch.diff (238 bytes) - added by Andre Steenveld 10 years ago.
Patch to make the checked multi select work on IE8
IE.CheckedMultiSelect.diff (528 bytes) - added by Andre Steenveld 10 years ago.
Patch

Download all attachments as: .zip

Change History (9)

Changed 10 years ago by vlad

demonstrates the problem

Changed 10 years ago by Andre Steenveld

Attachment: multiselect.ie.patch.diff added

Patch to make the checked multi select work on IE8

comment:1 Changed 10 years ago by Andre Steenveld

I attached a little fix, it appears that instead of "true" IE8 returns "multiple" when it is a multi select list.

comment:2 Changed 10 years ago by vlad

thank you, for some reason I do not see anything in the .diff file - could you please reattach the patch.

thank you

Changed 10 years ago by Andre Steenveld

Attachment: IE.CheckedMultiSelect.diff added

Patch

comment:3 Changed 10 years ago by vlad

thank you, your patch works. I hope maintainers notice that this problem is actually is in the dijit and not dojox as I specified earlier (and therefore more critical to address)

comment:4 Changed 10 years ago by bill

Milestone: tbd1.4
Owner: changed from dante to bill
Status: newassigned
Summary: CheckedMultiSelect shows RadioButtons instead of CheckBoxes on IE8[patch] [cla] CheckedMultiSelect shows RadioButtons instead of CheckBoxes on IE8

I'll take a look at the patch then (thanks for supplying it, Andre!)

comment:5 Changed 10 years ago by bill

That's a good local fix to the problem, but I feel like the root issue is that _FormSelectWidget.js is treating "multiple" as a string (and telling the parser to treat it as a string) when it's really a boolean, just like checked or disabled. By changing it to a boolean the code gets simpler and the need for the _multiSelect boolean (which is basically the same as "multiple" is gone.

comment:6 Changed 10 years ago by bill

Resolution: fixed
Status: assignedclosed

(In [20033]) Simplify code and resolve a bug by treating "multiple" like the boolean that it is, rather than as a string. Fixes #9680 !strict.

Note: See TracTickets for help on using tickets.