Opened 11 years ago
Closed 11 years ago
#9680 closed defect (fixed)
[patch] [cla] CheckedMultiSelect shows RadioButtons instead of CheckBoxes on IE8
Reported by: | vlad | Owned by: | bill |
---|---|---|---|
Priority: | high | Milestone: | 1.4 |
Component: | DojoX Form | Version: | 1.3.2 |
Keywords: | dojox.form, CheckedMultiSelect, IE8, RadioButton, multiple | Cc: | |
Blocked By: | Blocking: |
Description
on IE8 even if the multiple set to 'true' (or present) for the dojox.form.CheckedMultiSelect?
it still shows radiobuttons instead of checkboxes (and only allows to select one thing instead of multiple).
I am running on the trunk as of today
Using severity critical -- because there is no workaround I can come up with.
Attachments (3)
Change History (9)
Changed 11 years ago by
Attachment: | CheckedMultiSelect_IE8_PROBMLEM_1.html added |
---|
Changed 11 years ago by
Attachment: | multiselect.ie.patch.diff added |
---|
Patch to make the checked multi select work on IE8
comment:1 Changed 11 years ago by
I attached a little fix, it appears that instead of "true" IE8 returns "multiple" when it is a multi select list.
comment:2 Changed 11 years ago by
thank you, for some reason I do not see anything in the .diff file - could you please reattach the patch.
thank you
comment:3 Changed 11 years ago by
thank you, your patch works. I hope maintainers notice that this problem is actually is in the dijit and not dojox as I specified earlier (and therefore more critical to address)
comment:4 Changed 11 years ago by
Milestone: | tbd → 1.4 |
---|---|
Owner: | changed from dante to bill |
Status: | new → assigned |
Summary: | CheckedMultiSelect shows RadioButtons instead of CheckBoxes on IE8 → [patch] [cla] CheckedMultiSelect shows RadioButtons instead of CheckBoxes on IE8 |
I'll take a look at the patch then (thanks for supplying it, Andre!)
comment:5 Changed 11 years ago by
That's a good local fix to the problem, but I feel like the root issue is that _FormSelectWidget.js is treating "multiple" as a string (and telling the parser to treat it as a string) when it's really a boolean, just like checked or disabled. By changing it to a boolean the code gets simpler and the need for the _multiSelect boolean (which is basically the same as "multiple" is gone.
comment:6 Changed 11 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
demonstrates the problem