Opened 15 years ago
Closed 13 years ago
#968 closed enhancement (fixed)
Checkable MenuItem
Reported by: | joose | Owned by: | nonken |
---|---|---|---|
Priority: | high | Milestone: | 1.2 |
Component: | themes | Version: | 0.3 |
Keywords: | MenuItem | Cc: | Nathan Toone |
Blocked By: | Blocking: |
Description (last modified by )
Seems like MenuItem? is missing checkable menuitem, where you can select items on or off.. Like this:
Use foo * Use bar * Use Quux
So that would indicate that bar and quux are turned on. of course corresponding events to match turning on/off perhaps?
Attachments (4)
Change History (25)
comment:1 Changed 15 years ago by
Milestone: | 0.4 → 0.5 |
---|
comment:2 Changed 14 years ago by
Owner: | changed from anonymous to bill |
---|
Changed 14 years ago by
Attachment: | CheckableMenuItem.patch added |
---|
makes "checking" of menuitem possible
Changed 14 years ago by
Attachment: | CheckableMenuItem.js added |
---|
Now default values work as supposed. Also setChecked(boolean) is there.
comment:3 Changed 14 years ago by
Component: | Widgets → Dijit |
---|---|
Milestone: | 0.9 → 1.0 |
Hmm, will consider for 1.0.
comment:4 Changed 14 years ago by
Cc: | [email protected]… removed |
---|---|
Reporter: | changed from [email protected]… to joose |
comment:5 Changed 13 years ago by
Milestone: | 1.0 → 2.0 |
---|
Changed 13 years ago by
Attachment: | checkableMenu.diff added |
---|
Here's a patch against current head to implement this - if anyone is interested in resurrecting this issue.
comment:7 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
(In [14070]) Fixes #968 - adds dijit.CheckedMenuItem? for toggle-based menu items !strict
comment:9 Changed 13 years ago by
Component: | Dijit → a11y - review |
---|---|
Description: | modified (diff) |
Milestone: | 1.3 → 1.2 |
Resolution: | fixed |
Status: | closed → reopened |
Just sending to Becky for testing screen reader.
comment:10 Changed 13 years ago by
Cc: | nathan added |
---|
comment:11 Changed 13 years ago by
Owner: | changed from bill to Becky Gibson |
---|---|
Status: | reopened → new |
comment:12 Changed 13 years ago by
comment:13 Changed 13 years ago by
comment:14 Changed 13 years ago by
The aria roles and properties look correct. Unfortunately the screen reader doesn't understand checkable menuitems, yet, so it doesn't say anything different to distinguish the checkable from the regular menu items. However, the correct role is being set so it has been implemented properly.
However, all of the other menu items are counted and an AccessibleDescription? is generated that is "x of 8" where x is the number of the current menu item in the list of 8 items. With the 3 new checkable items added, it should be "x of 11" but the checkable menu items aren't counted and do not get an accessibleDescription. I filed this as a Firefox bug (https://bugzilla.mozilla.org/show_bug.cgi?id=441888) but when I look at the HTML in Firebug, I don't see the checkable items in the table that gets generated for the menu? Can anyone figure out why not? That may be the issue. The HTML in test_menu.html looks correct and the menu divs seem to be nested properly.
comment:15 Changed 13 years ago by
Component: | a11y - review → Dijit |
---|
correct aria has been implemented and firefox bug has been fixed so moving this out of a11y-review back to dijit.
comment:16 Changed 13 years ago by
Owner: | changed from Becky Gibson to nathan |
---|
comment:17 Changed 13 years ago by
Component: | Dijit → themes |
---|---|
Owner: | changed from nathan to nonken |
I think this is completed - with the exception of (possibly) having different icons than the ones used - Moving to nikolai since he is a bit better-qualified at making that decision.
comment:18 Changed 13 years ago by
Cc: | Nathan Toone added; nathan removed |
---|
comment:19 Changed 13 years ago by
comment:20 Changed 13 years ago by
I think the way it looks now is good and suggest closing the ticket, I tried with a no border image but using the standard checkbox somehow gives a more unified look, also because the sub menu icons are the same as everywhere as well
I made simple patch to make this possible. What it still requires actually is:
How it works, just add checkable="true" and default value is defined by isChecked (boolean)