Checkable MenuItem

[joose]

Seems like MenuItem? is missing checkable menuitem, where you can select items on or off.. Like this:

  Use foo
* Use bar
* Use Quux

So that would indicate that bar and quux are turned on. of course corresponding events to match turning on/off perhaps?

[joose]

I made simple patch to make this possible. What it still requires actually is:

• Image of "checked" thing.

• To make default value working (isChecked=true)

How it works, just add checkable="true" and default value is defined by isChecked (boolean)

[joose]

makes "checking" of menuitem possible

[joose]

Patch to test-file

[joose]

Now default values work as supposed. Also setChecked(boolean) is there.

[bill]

Hmm, will consider for 1.0.

[alex]

Milestone 2.0 deleted

[nathan]

Here's a patch against current head to implement this - if anyone is interested in resurrecting this issue.

[Nathan Toone]

(In [14070]) Fixes #968 - adds dijit.CheckedMenuItem? for toggle-based menu items !strict

[Nathan Toone]

(In [14072]) Refs #968 - fix role for a11y !strict

[bill]

Just sending to Becky for testing screen reader.

[Nathan Toone]

(In [14086]) Refs #968 - toggling should not happen when item is disabled !strict

[Nathan Toone]

(In [14106]) Refs #968 - remove width 100%, since it is not needed

[Becky Gibson]

The aria roles and properties look correct. Unfortunately the screen reader doesn't understand checkable menuitems, yet, so it doesn't say anything different to distinguish the checkable from the regular menu items. However, the correct role is being set so it has been implemented properly.

However, all of the other menu items are counted and an AccessibleDescription? is generated that is "x of 8" where x is the number of the current menu item in the list of 8 items. With the 3 new checkable items added, it should be "x of 11" but the checkable menu items aren't counted and do not get an accessibleDescription. I filed this as a Firefox bug (​https://bugzilla.mozilla.org/show_bug.cgi?id=441888) but when I look at the HTML in Firebug, I don't see the checkable items in the table that gets generated for the menu? Can anyone figure out why not? That may be the issue. The HTML in test_menu.html looks correct and the menu divs seem to be nested properly.

[Becky Gibson]

correct aria has been implemented and firefox bug has been fixed so moving this out of a11y-review back to dijit.

[nathan]

I think this is completed - with the exception of (possibly) having different icons than the ones used - Moving to nikolai since he is a bit better-qualified at making that decision.

[nonken]

(In [14285]) Optimized css, only using gif and fixed potential bug not displaying the checkboxes, refs #968

[nonken]

I think the way it looks now is good and suggest closing the ticket, I tried with a no border image but using the standard checkbox somehow gives a more unified look, also because the sub menu icons are the same as everywhere as well

[Nathan Toone]

Marking as closed then.