Changes between Initial Version and Version 1 of Ticket #9654


Ignore:
Timestamp:
Aug 4, 2009, 4:32:12 PM (10 years ago)
Author:
Jared Jurkiewicz
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #9654 – Description

    initial v1  
    1212[ Error: Statement on line 62: Type mismatch (usually non-object value supplied where object required) Backtrace: Line 62 of eval script bookmark = range.getBookmark(); ... Line 87 of eval script return callback.apply(thisObject, cbArguments || []); ... Line 58 of eval script return dojo.withDoc.call(null, globalObject.document, callback, thisObject, cbArguments); Line 379 of eval script var b=dojo.withGlobal(this.window,dijit.getBookmark); Line 407 of eval script this._steps.push({'text':this.savedContent,'bookmark':this._getBookmark()}); Line 256 of eval script this._beginEditing(); Line 238 of eval script this.editor.execCommand(this.editor._normalizeCommand(this.command), choice); ... Line 133 of eval script function(){ return method.apply(scope, arguments || []); } ... Line 45 of eval script lls[i].apply(this, arguments); Line 312 of eval script this.onChange(newValue); ... Line 133 of eval script function(){ return method.apply(scope, arguments || []); } ... ]
    1313
    14 This fails because the getBookmark code in _base/focus.js mistakenly detects Opera as IE (By assuming that document.selection only exists on IE.  This is wrong, it also exists on Opera.)  The problem is that code path only works on IE, so Opera blows up.  This is the smae discovery I made (and fixed), in tracker:
     14This fails because the getBookmark code in _base/focus.js mistakenly detects Opera as IE (By assuming that document.selection only exists on IE.  This is wrong, it also exists on Opera.)  The problem is that code path only works on IE, so Opera blows up.  This is the same discovery I made (and fixed), in tracker:
    1515
    1616http://bugs.dojotoolkit.org/ticket/9520
     
    1818Regarding selection (Very similar code in there).
    1919
    20 So ... the fix is also the same, use dojo.isIE instead to select the IE path.  I know this goes against the push by some to use 'feature detection' but I'm not sure how else to detect it's IE only and not msitakenly use IE codepaths for Opera.
     20So ... the fix is also the same, use dojo.isIE instead to select the IE path.  I know this goes against the push by some to use 'feature detection' but I'm not sure how else to detect it's IE only and not mistakenly use IE codepaths for Opera.
    2121
    22 When I applied a fix to focus, I was able to use customUndo with Editor.  It may fix other Opera bugs where code in dojo makes use fo dijit.getBookmark and the like.   Patch forthcoming.
     22When I applied a fix to focus, I was able to use customUndo with Editor.  It may fix other Opera bugs where code in dojo makes use of dijit.getBookmark and the like.   Patch forthcoming.