Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#9647 closed enhancement (fixed)

[PATCH][CCLA]: FontChoice plugins: Custom button doesn't expose 'disabled' attribute

Reported by: Jared Jurkiewicz Owned by:
Priority: high Milestone: 1.4
Component: Editor Version: 1.3.2
Keywords: Cc:
Blocked By: Blocking:

Description

FontChoice? plugins: Custom button doesn't expose 'disabled' attribute

The 'dijit._editor.plugins._FontDropDown' button doesn't expose the disabled attribute to allow for the button to be toggled off in specific situations (such as iterating over all editor plugins and disabling buttons in specific cases, such as view source). This is simple to add, thankfully. Patch for it forthcoming:

Attachments (1)

FontChoice_disabled.patch (651 bytes) - added by Jared Jurkiewicz 10 years ago.
Simple patch to expose the disabled attribute of the underlying select

Download all attachments as: .zip

Change History (4)

Changed 10 years ago by Jared Jurkiewicz

Attachment: FontChoice_disabled.patch added

Simple patch to expose the disabled attribute of the underlying select

comment:1 Changed 10 years ago by Jared Jurkiewicz

Summary: FontChoice plugins: Custom button doesn't expose 'disabled' attribute[PATCH][CCLA]: FontChoice plugins: Custom button doesn't expose 'disabled' attribute

comment:2 Changed 10 years ago by Jared Jurkiewicz

Resolution: fixed
Status: newclosed

(In [19502]) Minor update to FontChoice? to allow the custom buttons to be disabled like regular dijit buttons in plugins. fixes #9647

comment:3 Changed 10 years ago by bill

Milestone: tbd1.4
Note: See TracTickets for help on using tickets.