Numberspinner: remove default required=true

[mgordon]

I'm questioning the value of NumberSpinner? being forcefully set to required as it seems to work without the "required: true," parameter on Firefox 3.0.12 in Ubuntu.

If it is still necessary perhaps an explanation of which browsers that are affected by this would enable people to remove the required if it doesn't seem to apply to their target browsers.

This report is a result due to this discussion: ​http://mail.dojotoolkit.org/pipermail/dojo-interest/2009-August/037439.html

I've looked into the reported change and the bug also a little puzzled to the background of this required feature. I've attached one file with NumberSpinner? required commented out and a test which basically is the same as the reported bug together with a modern NumberSpinner?-example.

[mgordon]

The example file

[mgordon]

just commented out the required line

[bill]

Doug, that required is from [8279], a change of yours from a long time ago.

[mgordon]

I've checked my code in IE 6.0 under XP and it works

[Douglas Hays]

The required=true was added since we used to not allow blank values to be valid. It's not needed anymore but was left in for backward compatibility. I need a ack from bill to change it.

[bill]

Oh I see, OK, then yes please remove it. I don't think anyone will mind that change.

[Douglas Hays]

(In [19528]) Fixes #9643. Changed NumberSpinner? to have required=false as the default.