#9643 closed defect (fixed)
Numberspinner: remove default required=true
Reported by: | mgordon | Owned by: | Douglas Hays |
---|---|---|---|
Priority: | high | Milestone: | 1.4 |
Component: | Dijit - Form | Version: | 1.3.2 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
I'm questioning the value of NumberSpinner? being forcefully set to required as it seems to work without the "required: true," parameter on Firefox 3.0.12 in Ubuntu.
If it is still necessary perhaps an explanation of which browsers that are affected by this would enable people to remove the required if it doesn't seem to apply to their target browsers.
This report is a result due to this discussion: http://mail.dojotoolkit.org/pipermail/dojo-interest/2009-August/037439.html
I've looked into the reported change and the bug also a little puzzled to the background of this required feature. I've attached one file with NumberSpinner? required commented out and a test which basically is the same as the reported bug together with a modern NumberSpinner?-example.
Attachments (2)
Change History (9)
Changed 12 years ago by
comment:1 Changed 12 years ago by
Owner: | set to Douglas Hays |
---|
Doug, that required is from [8279], a change of yours from a long time ago.
comment:3 Changed 12 years ago by
The required=true was added since we used to not allow blank values to be valid. It's not needed anymore but was left in for backward compatibility. I need a ack from bill to change it.
comment:4 Changed 12 years ago by
Summary: | Numberspinner probably shouldn't need to be required → Numberspinner: remove default required=true |
---|
Oh I see, OK, then yes please remove it. I don't think anyone will mind that change.
comment:5 Changed 12 years ago by
Milestone: | tbd → 1.4 |
---|---|
Status: | new → assigned |
comment:6 Changed 12 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
(In [19528]) Fixes #9643. Changed NumberSpinner? to have required=false as the default.
comment:7 Changed 10 years ago by
Component: | Dijit → Dijit - Form |
---|
The example file