[PATCH][CCLA] dojox.editor.TablePlugins: Fail to load in FF2

[Jared Jurkiewicz]

The dojox.editor table plugins fail to load in FF2 using:

dojox/editor/tests/editorTablePlugs.html

With error: this.editor.iframe.document has no properties [Break on this error] (113 out of range 17)

This can be seen in nightly: ​file:///X:/dojo/trunk4/trunk/dojox/editor/tests/editorTablePlugs.html

This occurs because editor's iframe document loads asynchronously but the plugin's initialize function does not take that into account. There is an easy fix for this. Patch forthcoming

[Jared Jurkiewicz]

Patch for handling async init of iframe

[Jared Jurkiewicz]

Even with that patch I get another error (The plugins load at least!) of:

node has no properties [Break on this error] if(node.tagName.toLowerCase() == "iframe"){

Not sure where this is coming from. I couldn't find any code like that in the editor/RichText files or the TablePlugin? files.

[Jared Jurkiewicz]

Okay, that error is coming from Menu.js, line 373. Probably related to context menus in the TablePlugins?.

[Jared Jurkiewicz]

Hah, also related to delayed initialization issues. Updated patch coming!

[Jared Jurkiewicz]

Better patch, also fixes the node has no properties error.

[Jared Jurkiewicz]

Assigning over to Mike Wilcox for review (As he owns that dojox project)

[Mike Wilcox]

Patch applied. Tested that the patch didn't break anything, but didn't test if it fixed FF2 (it didn't fix IE anyway)

[Jared Jurkiewicz]

Verified, so closing.

[Adam Peller]

applied in [19366]