#9636 closed defect (fixed)
[PATCH][CCLA] dojox.editor.TablePlugins: Fail to load in FF2
Reported by: | Jared Jurkiewicz | Owned by: | Mike Wilcox |
---|---|---|---|
Priority: | high | Milestone: | 1.4 |
Component: | Dojox | Version: | 1.3.2 |
Keywords: | Cc: | Jared Jurkiewicz, Adam Peller | |
Blocked By: | Blocking: |
Description
The dojox.editor table plugins fail to load in FF2 using:
dojox/editor/tests/editorTablePlugs.html
With error: this.editor.iframe.document has no properties [Break on this error] (113 out of range 17)
This can be seen in nightly: file:///X:/dojo/trunk4/trunk/dojox/editor/tests/editorTablePlugs.html
This occurs because editor's iframe document loads asynchronously but the plugin's initialize function does not take that into account. There is an easy fix for this. Patch forthcoming
Attachments (2)
Change History (11)
Changed 12 years ago by
Attachment: | TablePlugins.patch added |
---|
comment:1 Changed 12 years ago by
Even with that patch I get another error (The plugins load at least!) of:
node has no properties [Break on this error] if(node.tagName.toLowerCase() == "iframe"){
Not sure where this is coming from. I couldn't find any code like that in the editor/RichText files or the TablePlugin? files.
comment:2 Changed 12 years ago by
Okay, that error is coming from Menu.js, line 373. Probably related to context menus in the TablePlugins?.
comment:3 Changed 12 years ago by
Hah, also related to delayed initialization issues. Updated patch coming!
Changed 12 years ago by
Attachment: | TablePlugins2.patch added |
---|
Better patch, also fixes the node has no properties error.
comment:4 Changed 12 years ago by
Summary: | dojox.editor.TablePlugins: Fail to load in FF2 → [PATCH][CCLA] dojox.editor.TablePlugins: Fail to load in FF2 |
---|
comment:5 Changed 12 years ago by
Owner: | changed from Adam Peller to Mike Wilcox |
---|
Assigning over to Mike Wilcox for review (As he owns that dojox project)
comment:6 Changed 12 years ago by
severity: | normal → critical |
---|
comment:7 Changed 12 years ago by
Cc: | Jared Jurkiewicz Adam Peller added |
---|---|
Milestone: | tbd → 1.4 |
severity: | critical → normal |
Patch applied. Tested that the patch didn't break anything, but didn't test if it fixed FF2 (it didn't fix IE anyway)
Patch for handling async init of iframe