Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#9630 closed defect (fixed)

Opera: dojo.analytics.Urchin script handling executes twice

Reported by: Les Owned by: dante
Priority: low Milestone: 1.4
Component: Dojox Version: 1.3.2
Keywords: Cc:
Blocked By: Blocking:

Description

According to Steve Souders Opera handles both onload and onreadystatechange for scripts, so the following code will be executed twice:

n.onload = n.onreadystatechange = dojo.hitch(this, function(e){
	if(e && e.type == "load" || re.test(n.readyState)){
		this._gotGA();
	}
});

Change History (6)

comment:1 Changed 10 years ago by Adam Peller

Owner: changed from Adam Peller to Dustin Machi

comment:2 Changed 10 years ago by Adam Peller

Summary: dojox/analytics Urchin.js - Opera issue.Opera: dojo.analytics.Urchin script handling executes twice

Not knowing anything about the code, does this fail in an obvious way? (how would one confirm that this is fixed?) Is it as simple as putting a sentinel around _gotGA?

comment:3 Changed 10 years ago by dante

Owner: changed from Dustin Machi to dante
Status: newassigned

of course opera should fire both. ugh.

comment:4 Changed 10 years ago by dante

Milestone: tbd1.4

comment:5 Changed 10 years ago by dante

Resolution: fixed
Status: assignedclosed

(In [19307]) fixes #9630 - null out both functions for cleanup, thus preventing opera from firing both events

comment:6 Changed 10 years ago by dante

(In [19308]) refs #9630 - use n instead of s (s was from my standalone test case, c/p over

Note: See TracTickets for help on using tickets.