Opened 10 years ago
Closed 6 years ago
#9626 closed defect (patchwelcome)
ColorPicker onChange event fires even if no change happened
| Reported by: | jose.noheda | Owned by: | dante |
|---|---|---|---|
| Priority: | high | Milestone: | 1.9 |
| Component: | DojoX Widgets | Version: | 1.3.2 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description
For example, it fires when it's created even if no value is assigned and it fires when a parent Dialog is closed but only if it's closed manually by clicking the X icon (and not programmatically!). IMO it should only be fired when the user selects a color or when the code sets the value attribute.
Attachments (1)
Change History (6)
Changed 10 years ago by
| Attachment: | color_onchange.html added |
|---|
comment:1 Changed 10 years ago by
| Milestone: | tbd → 1.5 |
|---|---|
| Status: | new → assigned |
comment:2 Changed 9 years ago by
| Milestone: | 1.5 → 1.6 |
|---|
comment:3 Changed 8 years ago by
| Milestone: | 1.6 → future |
|---|
comment:5 Changed 6 years ago by
| Milestone: | future → 1.9 |
|---|---|
| Resolution: | → patchwelcome |
| Status: | assigned → closed |
A patch would be welcome to fix this. Otherwise I don't think it will get fixed given the lack of activity.
Note: See
TracTickets for help on using
tickets.
that's reallly odd. Not sure what I'm seeing in my own local modified version. onChange is really firing for all? or me connecting to it and it using a common handler function? not sure. need to dig. Hopefully lots of ColorPicker? stuff in 1.5