Opened 10 years ago
Closed 7 years ago
#9623 closed defect (fixed)
[patch] [cla] Cache issue with dojox.dtl._Templated
| Reported by: | ID | Owned by: | ben hockey |
|---|---|---|---|
| Priority: | low | Milestone: | 1.8 |
| Component: | DojoX DTL | Version: | 1.3.2 |
| Keywords: | Cc: | ben hockey | |
| Blocked By: | Blocking: |
Description
Cache retrieving is not done properly in dojox.dtl._Templated.
This bug is only triggered when no Django tags are present and the widget is used more than once.
Patch attached
Attachments (2)
Change History (10)
comment:1 follow-up: 3 Changed 7 years ago by
| Owner: | changed from Neil Roberts to ID |
|---|---|
| Priority: | high → low |
| Status: | new → pending |
comment:2 Changed 7 years ago by
| Resolution: | → invalid |
|---|---|
| Status: | pending → closed |
Because we get so many tickets, we often need to return them to the initial reporter for more information. If that person does not reply within 14 days, the ticket will automatically be closed, and that has happened in this case. If you still are interested in pursuing this issue, feel free to add a comment with the requested information and we will be happy to reopen the ticket if it is still valid. Thanks!
comment:3 Changed 7 years ago by
Replying to neonstalwart:
can you provide a test case that demonstrates this problem so that i can confirm if your patch is still needed and what problem it fixes?
I've attached a test case that show how it fails. Basicaly when a template is used with no django tags. I've also updated the patch to the latest revision.
comment:4 Changed 7 years ago by
It says "patch attached" in the description but the only patch is for the tests, right?
Also ID, do you have a CLA filed? And if so, what name is it under?
Changed 7 years ago by
| Attachment: | dojox.dtl._Templated.patch added |
|---|
comment:5 Changed 7 years ago by
Sorry I messed up my diff command. Here is the patch that corrects the bug that I mention.
I just sent my CLA under the name Jérôme Heil
comment:6 Changed 7 years ago by
| Cc: | ben hockey added |
|---|---|
| Resolution: | invalid |
| Status: | closed → reopened |
| Summary: | Cache issue with dojox.dtl._Templated → [patch] [cla] Cache issue with dojox.dtl._Templated |
Ben, you checked in the other patches, maybe you can do this one too.
comment:7 Changed 7 years ago by
| Milestone: | future → 1.8 |
|---|---|
| Owner: | changed from ID to ben hockey |
| Status: | reopened → assigned |
sure - i'll take a look and hopefully get to it in the next few days.
can you provide a test case that demonstrates this problem so that i can confirm if your patch is still needed and what problem it fixes?