Opened 13 years ago

Last modified 6 years ago

#9622 closed enhancement

ContentPane: pre-processing callback for downloaded content — at Version 4

Reported by: Foam Head Owned by:
Priority: high Milestone: 1.11
Component: Dijit Version: 1.3.2
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

I'm working with a ContentPane that downloads its content via an href, but the content needs to be pre-processed before it is displayed. Despite having onLoad and onDownloadEnd callbacks, both of these are called *after* the content is displayed.

It looks like having onLoad fire after the content is displayed is identical in function to onDownloadEnd. I'm wondering if onLoad should be fired before the content is displayed. If onLoad and onDownloadEnd need to remain as is, then a new callback (onPreLoad? onDownloadPreprocess? preprocessDownload? preprocessContent?) should be added.

Note: My experience with this has been with a ContentPane, but the same pre-processing callback should be available in all classes that support downloading href content.

Change History (5)

comment:1 Changed 13 years ago by bill

Milestone: tbd1.5

comment:2 Changed 12 years ago by Marcin Gołębski

I vote for this change. In Dojo 1.1.0 the sequence of caling was as follows:

  1. <fetching document from server>
  2. onDownloadEnd()
  3. <fetched document parsing>
  4. onLoad()

and for me it was correct.

Now (DOJO 1.3.2 and up):

  1. <fetching document from server>
  2. <fetched document parsing>
  3. onLoad()
  4. onDownloadEnd()

so, onDownloadEnd is useless now, becouse is called just after onLoad.

I attached simple patch, whitch fixes this problem, is it correct approach?

Changed 12 years ago by Marcin Gołębski

Attachment: ContentPane.patch added

comment:3 Changed 12 years ago by Adam Peller

Milestone: 1.51.6

comment:4 Changed 11 years ago by bill

Description: modified (diff)
Milestone: 1.61.7
Summary: RFE: pre-processing callback for downloaded contentContentPane: pre-processing callback for downloaded content
Note: See TracTickets for help on using tickets.