Opened 13 years ago
Closed 13 years ago
#9615 closed defect (fixed)
FileUploader IE Error - invalid argument
Reported by: | Mike Wilcox | Owned by: | Mike Wilcox |
---|---|---|---|
Priority: | high | Milestone: | 1.4 |
Component: | DojoX Form | Version: | 1.3.2 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
There is a bug in FileUploader? that attempts to set the lineHeight to 'auto'. IE no likey.
This is fixed in the trunk of 1.4 The workaround for the 1.3.2 release is to path the method:
<script type="text/javascript"> dojo.require("dojo.html"); dojo.require("dojox.form.FileUploader"); dojox.form.FileUploader.prototype._styleContent = function(){ var o = this.fhtml.nr; var lh = dojo.isIE ? "inherit" : "auto"; dojo.style(this.insideNode, { width:o.w+"px", height:o.va == "middle"?o.h+"px":"auto", lineHeight:o.va == "middle"?o.h+"px":lh, textAlign:o.ta, paddingTop:o.p[0]+"px", paddingRight:o.p[1]+"px", paddingBottom:o.p[2]+"px", paddingLeft:o.p[3]+"px" }); } </script>
Change History (7)
comment:1 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:2 Changed 13 years ago by
it is helpful to also reference the checkin number so people can see the patch without digging.
this was fixed in [19088]
comment:3 Changed 13 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
This bug still persists. IE doesn't like inherit nor auto in some cases of which I cannot determine.
comment:4 Changed 13 years ago by
comment:5 Changed 13 years ago by
Milestone: | 1.4 → 1.3.3 |
---|
comment:6 Changed 13 years ago by
That patch didn't work after all. IE has a very stubborn bug that involves some kind of combination of variables that makes it not want to set the line height. Here is the latest patch:
<script type="text/javascript"> dojo.require("dojo.html"); dojo.require("dojox.form.FileUploader"); dojox.form.FileUploader.prototype._styleContent = function(){ var o = this.fhtml.nr; dojo.style(this.insideNode, { width:o.w+"px", height:o.va == "middle"?o.h+"px":"auto", textAlign:o.ta, paddingTop:o.p[0]+"px", paddingRight:o.p[1]+"px", paddingBottom:o.p[2]+"px", paddingLeft:o.p[3]+"px" }); try{ dojo.style(this.insideNode, "lineHeight", "inherit"); }catch(e){ // squelch } } </script>
comment:7 Changed 13 years ago by
Milestone: | 1.3.3 → 1.4 |
---|---|
Resolution: | → fixed |
Status: | reopened → closed |
Fixed in the trunk.
Note: See
TracTickets for help on using
tickets.
This is fixed in a previous commit. Made the ticket for reference.