Opened 10 years ago

Closed 9 years ago

Last modified 9 years ago

#9613 closed defect (fixed)

Editor: undo enabled on initialize (safari)

Reported by: bill Owned by: Jared Jurkiewicz
Priority: high Milestone: 1.5
Component: Editor Version: 1.3.2
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

See test_Editor.html on safari.

The undo button for all the editors is enabled on page load, even though there's nothing to undo.

Change History (8)

comment:1 Changed 10 years ago by bill

Description: modified (diff)
Summary: Editor: undo enabled on initializeEditor: undo enabled on initialize (safari)

comment:2 Changed 10 years ago by dante

Owner: set to Jared Jurkiewicz

comment:3 Changed 10 years ago by bill

Milestone: tbdfuture
Owner: Jared Jurkiewicz deleted

comment:4 Changed 9 years ago by Jared Jurkiewicz

This can be easily worked around by setting customUndo. The main issue is Safari's native execCommand/QueryCommandValue return true for undo, even when there is nothing to undo.

Just set the customUndo param of the editor to true and the problem will go away.

comment:5 Changed 9 years ago by Jared Jurkiewicz

Owner: set to Jared Jurkiewicz

comment:6 Changed 9 years ago by Jared Jurkiewicz

Resolution: fixed
Status: newclosed

(In [22049]) Small fix to WebKit? by turning on customUndo, fixes the undo being enabled on initalization. \!strict fixes #9613

comment:7 Changed 9 years ago by bill

Milestone: future1.5

comment:8 Changed 9 years ago by bill

(In [22986]) Now that customUndo is enabled for webkit, we don't need this block of code. Refs #9613 (specifically [22049]), !strict.

Note: See TracTickets for help on using tickets.