Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#9588 closed enhancement (fixed)

Dialog: support resizing of child widget

Reported by: Adam Peller Owned by: bill
Priority: high Milestone: 1.4
Component: Dijit Version: 1.3.2
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

Consider a preferences dialog which is a dijit.Dialog with a single BorderContainer widget in its contents. The BorderContainer must have a size, and the Dialog may resize itself to fit in the viewport, leaving the Dialog contents with a scrollbar. It should be possible to have the dialog resize the single child widget in this situation. I think this is related to the doLayout feature from ContentPane?

Change History (3)

comment:1 Changed 10 years ago by bill

Description: modified (diff)
Milestone: tbd1.4
Owner: set to bill
Status: newassigned
Summary: Dialog should support resizing of child widgetDialog: support resizing of child widget

It is related to doLayout, although a little different.

Normally the dialog's size is determined by it's contents; that's why doLayout is false. But in the special case where the dialog reduces the size of it's contents so the dialog itself fits in the viewport, it makes sense to do the resize of the single child widget like ContentPane does.

Actually this can already be tested with test_Dialog.html, with the TabContainer example.

comment:2 Changed 10 years ago by bill

Resolution: fixed
Status: assignedclosed

(In [19277]) When a Dialog's size needs to be reduced to fit in the viewport, and that Dialog contains a single layout widget, resize the layout widget, rather than adding a scrollbar to Dialog.containerNode.

Fixes #9588 !strict.

comment:3 Changed 10 years ago by bill

(In [19278]) Remove "janktastic solution to #8967", which is no longer needed after [19277], since Lightbox doesn't even call Dialog._size(). Refs #8967, #9588 !strict.

Note: See TracTickets for help on using tickets.