Opened 5 years ago

Last modified 5 years ago

#9582 new defect

Invalid iconClassPrefix in TablePlugins.js and UploadImage.js

Reported by: oliver_ Owned by: mwilcox
Priority: high Milestone: future
Component: Dojox Version: 1.3.0
Keywords: dijit editor buttons styles classes missing table image upload plugin Cc:
Blocked by: Blocking:

Description

The Dojox Plugins TablePlugins and UploadImage have a wrong iconClassPrefix set.

Instead of iconClassPrefix:"editorIcon" it should be iconClassPrefix:"dijitEditorIcon" in line 214 of dojox/editor/plugins/TablePlugins.js and line 14 of dojox/editor/plugins/UploadImage.js, respectively.

This bug causes the icons for the buttons of these plugins (in the Dijit Editor) to be absent in Dojo Version 1.3.0 due to the lack of a editorIcon CSS class.

Change History (6)

comment:1 Changed 5 years ago by dante

  • Milestone changed from tbd to 1.4
  • Owner changed from peller to dante
  • Status changed from new to assigned

comment:2 Changed 5 years ago by peller

fixed?

comment:3 Changed 5 years ago by dante

  • Resolution set to fixed
  • Status changed from assigned to closed

yep, in [19067] -- postCommit hooks must be b0rked. sorry about that.

comment:4 Changed 5 years ago by oliver_

  • Resolution fixed deleted
  • Status changed from closed to reopened

Actually I'm not sure whether this change is a good idea. Having added more buttons from the table plugin, I noticed they were absent too, which prompted me to dig deeper into the code which made me realize that there is only a class for dijitEditorIconInsertTable, but not for dijitEditorIconModifyTable and so on. I found that for the plugins, there is a separate CSS file existing in dojox/editor/plugins/resources/editorPlugins.css defining the needed classes editorIconInsertTable, editorIconModifyTable, ...

Sorry about that, I'm quite new to using Dojo and am not quite aware of the underlying structures yet. Since the editor is skinnable, I would have supposed it uses the skin CSS at dijit/themes instead of a separate CSS, where the icons stand out quite a bit from the rest of the design. So I suppose that's no problem at all, and reverting changes and loading the separate CSS should do. I'm sorry for the trouble!

comment:5 Changed 5 years ago by dante

  • Owner changed from dante to mwilcox
  • Status changed from reopened to new

no trouble, this is a documentation fail. The css is linked in the two tests, but they don't follow ANY of our conventions (mixed tab/whitespace, tests are prefixed with test_, inline comments in the test, etc).

@mike, can you please clean this up. svn blame says you own him :)

comment:6 Changed 5 years ago by mwilcox

  • Milestone changed from 1.4 to future
Note: See TracTickets for help on using tickets.