Opened 10 years ago

Closed 10 years ago

#9569 closed defect (worksforme)

Make attr("title") setting work in TitlePane

Reported by: Shane O'Sullivan Owned by:
Priority: high Milestone: tbd
Component: Dijit Version: 1.3.1
Keywords: Cc:
Blocked By: Blocking:

Description

The dijit.TitlePane? widget has deprecated the setTitle function, but has not replaced it with a corresponding _setTitleAttr function. When widget.attr("title", "some value") is called, the widgets title is not updated visually.

Attachments (1)

titlepane.html (978 bytes) - added by dante 10 years ago.
proves .attr works before this change

Download all attachments as: .zip

Change History (11)

comment:1 Changed 10 years ago by Shane O'Sullivan

(In [18930]) Refs #9569 Fixes issue where calling titlePane.attr("title", "some value") does not visually update the title bar. The deprecated setTitle() function now delegates to _setTitleAttr() Also added an example to the Portlet test case showing how to dynamically update the title bar

comment:2 Changed 10 years ago by Shane O'Sullivan

Resolution: fixed
Status: newclosed

comment:3 Changed 10 years ago by dante

Resolution: fixed
Status: closedreopened

This code is unnecessary. instance.attr("title") and instance.attr("title", "New Title") already updates both the .title property and the .innerHTML of the titleNode via attributeMap. The function added needs backed out.

Also, don't fix something as fixed without a milestone, though in this case it is irrelevant.

Changed 10 years ago by dante

Attachment: titlepane.html added

proves .attr works before this change

comment:4 Changed 10 years ago by dante

(In [18931]) refs #9569 - adding in a .attr(title) set/get test to titlepane

comment:5 Changed 10 years ago by dante

Resolution: fixed
Status: reopenedclosed

(In [18932]) fixes #9569 as invalid, backing out _setTitleAttr

comment:6 Changed 10 years ago by Shane O'Sullivan

Hmm, I tested this, and attr("title", "new title value") didn't work. After the change it did. Are you sure it works without this fix?

comment:7 Changed 10 years ago by Shane O'Sullivan

Upon retesting, it now works, which is strange. Apologies for this.

comment:8 Changed 10 years ago by dante

yes, the test added to test_TitlePane.html shows it working. The attached test shows it working with either trunk or 1.3.2 from CDN

comment:9 Changed 10 years ago by bill

Resolution: fixed
Status: closedreopened

comment:10 Changed 10 years ago by bill

Resolution: worksforme
Status: reopenedclosed
Note: See TracTickets for help on using tickets.