Opened 12 years ago
Closed 11 years ago
#9540 closed defect (fixed)
Dialog: fails on IE8 if the style="width: ..." passed in programmatic creation
Reported by: | vlad | Owned by: | bill |
---|---|---|---|
Priority: | high | Milestone: | 1.4 |
Component: | Dijit | Version: | 1.3.1 |
Keywords: | Cc: | Adam Peller | |
Blocked By: | Blocking: |
Description (last modified by )
<script> var dialog=new dijit.Dialog( {id:"idMyDLG", title: "test dialog", style:"height:80%;", modal:false }, document.createElement('div')); dojo.body().appendChild(dialog.domNode); dialog.show(); </script>
Attachments (1)
Change History (8)
comment:1 Changed 12 years ago by
Description: | modified (diff) |
---|
comment:2 Changed 12 years ago by
Ok, attached the test case. The documentation (I checked before loging) did not prohibit the style param to the dialog http://api.dojotoolkit.org/jsdoc/HEAD/dijit.Dialog (or at least I am reading it as such).
Styles seem to work (my particular need is to make the border green or red and make sure my grid fits in there).
So the only style that causes an error only on IE8 is the 'width'. In the test case attached I have commented out the 'style' that works and left uncommented the style that does not.
I can eventually put an 'if' statement for IE8 -- because on other browsers the styles work with no problems.
I was just uncertain if I was getting into more troubles with styling on IE8.
comment:3 Changed 12 years ago by
Ok, sorry forgot to answer your other question
The error I get is
Line: 90 Error: 'dijit._underlay' is null or not an object
and if I ignore this error (in IE8 debugger) a good lookin dialog gets still displayed
comment:4 Changed 12 years ago by
Owner: | set to bill |
---|---|
Summary: | dijit.Dialog fails on IE8 if the style attribute is passed in programmatic creation → Dialog: fails on IE8 if the style="width: ..." passed in programmatic creation |
I meant to say that Dialog isn't designed to take a width/height style; I agree that border should work. Incidentally specifying a style like background-color would also be strange since it's unclear which node's background-color you are talking about.
Anyway, I'll check out the test case.
comment:5 Changed 12 years ago by
Cc: | Adam Peller added |
---|
See also #9558. Hopefully these two can be fixed together.
comment:7 Changed 11 years ago by
Milestone: | tbd → 1.4 |
---|---|
Resolution: | → fixed |
Status: | new → closed |
I tried your test case; it's failing on 1.3 but working on trunk, so we've fixed this along the way somehow.
But Dialog isn't setup to take a style parameter at all... it sizes itself based on it's content. You didn't say in what way it fails but I think this will be wontfix.
Also, please attach testcases using the "attach file" button, thanks.