Opened 10 years ago

Closed 10 years ago

#9522 closed defect (fixed)

grid resize doesn't check whether his.domNode is set.

Reported by: rct Owned by: Bryan Forbes
Priority: high Milestone: 1.4
Component: DojoX Grid Version: 1.3.1
Keywords: dojox/grid resize, this.domNode is null Cc:
Blocked By: Blocking:

Description

Ticket #4892, provided additional checks for grid's resize to test whether this.domNode.parentNode is set and valid, however, it doesn't check whether this.domNode is set before attempting to de-reference this.domNode.

I'm running into this when closing a tab that contains a grid in a border container. I'm probably doing something wrong, but the grid's resize is being called after it has been removed from the borderContainer by the tab's close.

I believe it should be: 

_resize: function(changeSize, resultSize)
    if(!this.domNode){return;}  
    var pn = this.domNode.parentNode;
    if (!pn || pn.nodeType ...

Attachments (1)

grid-resize-diff.patch​ (504 bytes) - added by rct 10 years ago.
patch (not sure why trac viewer isn't displaying it.)

Download all attachments as: .zip

Change History (3)

Changed 10 years ago by rct

Attachment: grid-resize-diff.patch​ added

patch (not sure why trac viewer isn't displaying it.)

comment:1 Changed 10 years ago by Nathan Toone

Milestone: tbd → 1.4

comment:2 Changed 10 years ago by Nathan Toone

Resolution: → fixed
Status: new → closed

(In [20274]) Fixes #9522 - make sure domNode is still valid when trying to resize - since resize happens on a timeout sometimes. !strict

Note: See TracTickets for help on using tickets.