[PATCH][CCLA]FontChoice plugin should include the label and button node in a <span> with a stype of whiteSpace: nowrap

[Jared Jurkiewicz]

FontChoice? plugin should include the label and button node in a <span> with a style of whiteSpace: nowrap

This is so that when the page/toolbar is reduced, the label goes along with the dropdown. It looks much nicer that way. Breaking between the label and the dropdown looks ugly.

[Jared Jurkiewicz]

FontChoice? update to keep labels with the dropdown.

[Jared Jurkiewicz]

Example of bad splitting on wrap

[Jared Jurkiewicz]

Same page, with fix applied. Note that the label follows the box on splitting.

[bill]

Looks good to me. I was going to mention that this should be done for all the editor plugins w/labels, but apparently all the curent plugins w/labels are handled by that FontChoice.js.

One nitpicky thing is that you could use a single call to dojo.create() rather than calling dojo.doc.createElement(), dojo.style(), and dojo.place(). IIRC this should work (and save a few bytes in the code size):

dojo.create("span", {style: {whiteSpace: "noWrap"}}, this.button.domNode, "before");

Actually it's probably better to refactor that code to work off a template, does this work?

var span = dojo.place(
    "<span style='whiteSpace: nowrap'><label for="+this.button.id+">"+strings[this.command]+"</label></span>", 
    this.button.domNode, "before");
span.appendChild(this.button.domNode);

[liucougar]

agree with bill, dojo.place looks a better fit here

[Jared Jurkiewicz]

(In [18746]) Fixing minor issue with the FontChoice? plugin. Does not wrap very well. fixes #9521

[Jared Jurkiewicz]

(In [18782]) Discovered just the span breaks keyboard access. Needed a wrapper widget to make keyboard work right. refs #9521

[bill]

In [27187]:

add comment, refs #9521 !strict