Opened 10 years ago

Closed 10 years ago

#9512 closed enhancement (fixed)

Allow DOH to run in an iframe

Reported by: jeresig Owned by: liucougar
Priority: high Milestone: 1.4
Component: TestFramework Version: 1.3.0
Keywords: Cc:
Blocked By: Blocking:

Description

Currently DOH is incapable of running while it is contained within an iframe. There doesn't appear to be a technical limitation on why this occurs other than some unnecessary conditionals preventing it from working correctly.

I've attached a patch which should resolve this issue (I'm already a member of the Dojo foundation, via Sizzle).

Attachments (3)

doh-iframe.patch​ (2.7 KB) - added by jeresig 10 years ago.
Patch for adding in iframe support (also removes a dead code branch). Apply in util/doh.
doh-iframe.2.patch​ (2.1 KB) - added by jeresig 10 years ago.
Fixes the DOH runner to work in iframes.
9516.diff​ (1.3 KB) - added by liucougar 10 years ago.

Download all attachments as: .zip

Change History (6)

Changed 10 years ago by jeresig

Attachment: doh-iframe.patch​ added

Patch for adding in iframe support (also removes a dead code branch). Apply in util/doh.

Changed 10 years ago by jeresig

Attachment: doh-iframe.2.patch​ added

Fixes the DOH runner to work in iframes.

comment:1 Changed 10 years ago by liucougar

I opened #9516 and attached a patch there for this very issue (even the title is almost identical)

my patch is basically the same as the second patch attached here, but touches fewer lines and with a bit more comment

Changed 10 years ago by liucougar

Attachment: 9516.diff​ added

comment:2 Changed 10 years ago by liucougar

Milestone: tbd → 1.4
Owner: changed from alex to liucougar

comment:3 Changed 10 years ago by liucougar

Resolution: → fixed
Status: new → closed

(In [19939]) fixes #9512: allow doh to run within iframe !strict

Note: See TracTickets for help on using tickets.